599887 - [Cocoa] keydown event isn't fired during auto repeat

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(still sick)]

Attachment: Patch v1.0

See http://dev.w3.org/2006/webapi/DOM-Level-3-Events/html/DOM3-Events.html#events-keyboard-event-order

keydown events must be dispatched when auto repeating key event dispatches keypress event.

This is similar to bug 597981, but this isn't a regression on Mac.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(still sick)]

This isn't a regression, so, we shouldn't fix this bug on branches.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(still sick)]

Comment on attachment 478785 [details] [diff] [review]
Patch v1.0

Steven, could you review this patch?

Comment 3

[Steven Michaud [:smichaud] (Retired)]

Comment on attachment 478785 [details] [diff] [review]
Patch v1.0

This looks fine to me, though I haven't tested it.

As far as I know it doesn't (currently) make any practical difference
-- I don't believe current OS X versions ever send us repeat key
events.

I tried and failed to track down when the "if (![theEvent isARepeat])"
that you removed was added to the code.  Do you have any ideas, Josh,
why it was there?

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(still sick)]

https://developer.mozilla.org/en/DOM/Event/UIEvent/KeyEvent#Order_of_key_events

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(still sick)]

> I tried and failed to track down when the "if (![theEvent isARepeat])"
> that you removed was added to the code.  Do you have any ideas, Josh,
> why it was there?

I guess that he used same logic as old mac widget or gtk2 widget.

I'll land the patch tomorrow even if josh won't review it.

Comment 6

[Josh Aas]

(In reply to comment #5)
> > I tried and failed to track down when the "if (![theEvent isARepeat])"
> > that you removed was added to the code.  Do you have any ideas, Josh,
> > why it was there?
> 
> I guess that he used same logic as old mac widget or gtk2 widget.

This is correct. I was copying that logic.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(still sick)]

http://hg.mozilla.org/mozilla-central/rev/1f8d775d79b1