599958 - Tinderboxpushlog looks odd when no builds are generated for a platform

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Shawn Wilsher :sdwilsh]

With the new try: syntax, you can turn off platforms and it will generate no results.  However, tbpl ends up merging the platforms in one line when they are empty, so you end up getting something like this:
OS X64 debug    Win opt    Win debug   Android opt B

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

It can also look odd without try-chooser syntax: vlad's push that's currently on-top on try doesn't seem to have used try-chooser syntax, and it has OS X opt and OS X debug on the same line (at least until tests run?):

[e-mail] – Mon Sep 27 14:01:57 2010 PDT
ff919d075655     Vladimir Vukicevic – b=599698; remove UpdateSurfaceClip speedtrap in canvas drawImage; r+a=shaver
[...]
OS X opt  OS X debug   B

I suspect the removal of the ppc/i386 Universal (OS X opt) 'build' build has triggered this, also.

Comment 2

[Arpad Borsos [:Swatinem]]

When running results finish and end up under another push, they are removed from the old push but can leave behind an empty os row. Will post a patch tomorrow.

Comment 3

[Arpad Borsos [:Swatinem]]

Attachment: patch

Comment 4

[Arpad Borsos [:Swatinem]]

http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/c7d328a853ab