599970 - Add GetInterface for nsIEventTarget on Connection

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, defect)

Description

[Shawn Wilsher :sdwilsh]

It could be useful for consumers to post an event to the async thread.  However, this would be a *highly* advanced operation that most consumers wouldn't need, so we should make Connection implement nsIInterfaceRequester, and when it is asked for an nsIEventTarget, go ahead a return the background thread.

Comment 1

[Shawn Wilsher :sdwilsh]

Patch I have needs to be applied on top of bug 596970 (not a typo, it is in fact 3000 less than this bug)

Comment 2

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

BAM

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 481060 [details] [diff] [review]
v1.0

I presume "*highly* advanced operation" === "do not document this on the IDL; for use only by those proficient in precisely shooting between their toes"?

I'm going to treat this as a warranty voiding operation.  Specifically, this adds some potentially new situations where a reference can go out of scope on the async thread that are not already covered but I'm not going to look into those.  That's on whomever writes the code that dispatches to the async thread...

Comment 4

[Shawn Wilsher :sdwilsh]

(In reply to comment #3)
> I presume "*highly* advanced operation" === "do not document this on the IDL;
> for use only by those proficient in precisely shooting between their toes"?
Yup.

> I'm going to treat this as a warranty voiding operation.  Specifically, this
> adds some potentially new situations where a reference can go out of scope on
> the async thread that are not already covered but I'm not going to look into
> those.  That's on whomever writes the code that dispatches to the async
> thread...
Yeah, there were a few threadsafety things I thought about defending against, but then I realized that doing this means you damn well better know what you are doing or you will go boom somewhere anyway.

Comment 5

[Shawn Wilsher :sdwilsh]

http://hg.mozilla.org/projects/places/rev/1114c0304d82

Comment 6

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/1114c0304d82