Running ts_cold_generated_* tests on windows and should not

RESOLVED FIXED

Status

Testing
Talos
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: sdwilsh, Assigned: alice)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
We are running the ts_cold_generated_* tests on windows, but we shouldn't since we have no way to clear the cache.  On the plus side, this means we get more talos time given back to the pool :)
(Assignee)

Comment 1

7 years ago
This was an oversite when the dirty tests were initially created.
(Assignee)

Comment 2

7 years ago
Created attachment 478875 [details] [diff] [review]
[checked in] do not run any of the cold tests on windows
Attachment #478875 - Flags: review?(lsblakk)
(Assignee)

Updated

7 years ago
Component: Release Engineering → Talos
Product: mozilla.org → Testing
QA Contact: release → talos
Version: other → unspecified
(Assignee)

Updated

7 years ago
Assignee: nobody → anodelman
Comment on attachment 478875 [details] [diff] [review]
[checked in] do not run any of the cold tests on windows


>-BRANCHES['mozilla-central']['cold_tests'] = (1, True, {}, NO_WIN)
>+BRANCHES['mozilla-central']['cold_tests'] = (1, True, TALOS_DIRTY_OPTS, NO_WIN)

Was this tested?  I don't understand why all the cold_tests now have TALOS_DIRTY_OPTS passed in.
Comment on attachment 478875 [details] [diff] [review]
[checked in] do not run any of the cold tests on windows

looks good.
Attachment #478875 - Flags: review?(lsblakk) → review+
(Assignee)

Comment 5

7 years ago
Cleared up with lsblakk that we need the dirty profile options as these are dirty+cold tests, so they need the generated profiles to test against.
(Assignee)

Updated

7 years ago
Blocks: 593081
This landed, and I no longer see any cold builders for Windows.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Comment on attachment 478875 [details] [diff] [review]
[checked in] do not run any of the cold tests on windows

Landed in 883c318795a2
Attachment #478875 - Attachment description: do not run any of the cold tests on windows → [checked in] do not run any of the cold tests on windows
You need to log in before you can comment on or make changes to this bug.