600029 - Running ts_cold_generated_* tests on windows and should not

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Shawn Wilsher :sdwilsh]

We are running the ts_cold_generated_* tests on windows, but we shouldn't since we have no way to clear the cache.  On the plus side, this means we get more talos time given back to the pool :)

Comment 1

[alice nodelman [:alice] [:anode]]

This was an oversite when the dirty tests were initially created.

Comment 2

[alice nodelman [:alice] [:anode]]

Attachment: [checked in] do not run any of the cold tests on windows

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 478875 [details] [diff] [review]
[checked in] do not run any of the cold tests on windows


>-BRANCHES['mozilla-central']['cold_tests'] = (1, True, {}, NO_WIN)
>+BRANCHES['mozilla-central']['cold_tests'] = (1, True, TALOS_DIRTY_OPTS, NO_WIN)

Was this tested?  I don't understand why all the cold_tests now have TALOS_DIRTY_OPTS passed in.

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 478875 [details] [diff] [review]
[checked in] do not run any of the cold tests on windows

looks good.

Comment 5

[alice nodelman [:alice] [:anode]]

Cleared up with lsblakk that we need the dirty profile options as these are dirty+cold tests, so they need the generated profiles to test against.

Comment 6

[[e-mail] (:bhearsum)]

This landed, and I no longer see any cold builders for Windows.

Comment 7

[[e-mail] (:bhearsum)]

Comment on attachment 478875 [details] [diff] [review]
[checked in] do not run any of the cold tests on windows

Landed in 883c318795a2