Last Comment Bug 600029 - Running ts_cold_generated_* tests on windows and should not
: Running ts_cold_generated_* tests on windows and should not
Status: RESOLVED FIXED
:
Product: Testing
Classification: Components
Component: Talos (show other bugs)
: unspecified
: All Windows 7
: -- normal (vote)
: ---
Assigned To: alice nodelman [:alice] [:anode]
:
Mentors:
Depends on:
Blocks: releng-downtime
  Show dependency treegraph
 
Reported: 2010-09-27 14:47 PDT by Shawn Wilsher :sdwilsh
Modified: 2010-10-04 07:47 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
[checked in] do not run any of the cold tests on windows (9.55 KB, patch)
2010-09-27 14:53 PDT, alice nodelman [:alice] [:anode]
lukasblakk+bugs: review+
Details | Diff | Splinter Review

Description Shawn Wilsher :sdwilsh 2010-09-27 14:47:26 PDT
We are running the ts_cold_generated_* tests on windows, but we shouldn't since we have no way to clear the cache.  On the plus side, this means we get more talos time given back to the pool :)
Comment 1 alice nodelman [:alice] [:anode] 2010-09-27 14:52:26 PDT
This was an oversite when the dirty tests were initially created.
Comment 2 alice nodelman [:alice] [:anode] 2010-09-27 14:53:44 PDT
Created attachment 478875 [details] [diff] [review]
[checked in] do not run any of the cold tests on windows
Comment 3 Lukas Blakk [:lsblakk] use ?needinfo 2010-09-27 15:08:08 PDT
Comment on attachment 478875 [details] [diff] [review]
[checked in] do not run any of the cold tests on windows


>-BRANCHES['mozilla-central']['cold_tests'] = (1, True, {}, NO_WIN)
>+BRANCHES['mozilla-central']['cold_tests'] = (1, True, TALOS_DIRTY_OPTS, NO_WIN)

Was this tested?  I don't understand why all the cold_tests now have TALOS_DIRTY_OPTS passed in.
Comment 4 Lukas Blakk [:lsblakk] use ?needinfo 2010-09-27 15:15:27 PDT
Comment on attachment 478875 [details] [diff] [review]
[checked in] do not run any of the cold tests on windows

looks good.
Comment 5 alice nodelman [:alice] [:anode] 2010-09-27 15:16:24 PDT
Cleared up with lsblakk that we need the dirty profile options as these are dirty+cold tests, so they need the generated profiles to test against.
Comment 6 Ben Hearsum (:bhearsum) 2010-10-04 07:43:43 PDT
This landed, and I no longer see any cold builders for Windows.
Comment 7 Ben Hearsum (:bhearsum) 2010-10-04 07:47:17 PDT
Comment on attachment 478875 [details] [diff] [review]
[checked in] do not run any of the cold tests on windows

Landed in 883c318795a2

Note You need to log in before you can comment on or make changes to this bug.