Closed Bug 600064 Opened 13 years ago Closed 13 years ago

TraceMallocOpenLogFile lets sites create files with chosen names, at chosen locations

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b7

People

(Reporter: jruderman, Assigned: dbaron)

References

(Blocks 1 open bug)

Details

(Keywords: testcase, Whiteboard: [sg:moderate] --enable-trace-malloc builds only)

Attachments

(2 files)

testcase (requires a debug build)
206 bytes, text/html
Details
patch
3.77 KB, patch
jst
: review+
roc
: approval2.0+
Details | Diff | Splinter Review 
      No description provided.
This requires more than a debug build; it requires a build with --enable-trace-malloc, which is not on by default even for debug builds.
TraceMallocDumpAllocations has the same issue.
That explains why I started seeing this when I switched from local debug builds to Tinderbox debug builds.
Probably the best thing to do here is make these functions check for UniversalXPConnect.
Attached patch patch — — Splinter Review 
I think we're better off protecting people who build with trace-malloc.  If somebody needs these somewhere UniversalXPConnect is hard to get, they can always comment them out.
Assignee: nobody → dbaron
Status: NEW → ASSIGNED
Attachment #481344 - Flags: review?
Attachment #481344 - Flags: review? → review?(jst)
Attachment #481344 - Flags: review?(jst) → review+
Attachment #481344 - Flags: approval2.0?
http://hg.mozilla.org/mozilla-central/rev/5ba88998be23
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Group: core-security
Whiteboard: [sg:moderate] → [sg:moderate] --enable-trace-malloc builds only
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in before you can comment on or make changes to this bug.