600097 - Opening open search popup dismiss the Virtual Keyboard

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Step to reproduce:
 * launch fennec
 * open the awesome bar
 * type some letters
 * click on the search button on the right of the awesome bar

Actual results:
 * The list of search engines is displayed, then VKB is dismissed

Expected results:
 * The list of search engines is displayed

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Does this mean the VKB will be visible while the list of search engines is displayed?

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

I had some difficulty understanding the problem here. This is another summary of the steps:

* I tap on the [search] button
* The search providers appear, centered in available screen space
* The vkbd goes away
* The search provider list re-centers itself in newly available screen space

The re-center can be a problem if the delay is long enough and the user starts to press a button in the provider list before the list is re-centered.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #1)
> Does this mean the VKB will be visible while the list of search engines is
> displayed?

Yep, but typing a letter will dismiss the VKB

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #3)
> (In reply to comment #1)
> > Does this mean the VKB will be visible while the list of search engines is
> > displayed?

Sorry for the last comment, I meant typing a letter will dismiss the search engines menulist popup.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #1)
> > > Does this mean the VKB will be visible while the list of search engines is
> > > displayed?
> 
> Sorry for the last comment, I meant typing a letter will dismiss the search
> engines menulist popup.

Why do we want to see the VKB _and_ the search provider list? There doesn't seem to be enough screen space for that. I think the VKB should disappear when the search providers are shown.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > (In reply to comment #1)
> > > > Does this mean the VKB will be visible while the list of search engines is
> > > > displayed?
> > 
> > Sorry for the last comment, I meant typing a letter will dismiss the search
> > engines menulist popup.
> 
> Why do we want to see the VKB _and_ the search provider list? There doesn't
> seem to be enough screen space for that. I think the VKB should disappear when
> the search providers are shown.

It can looks strange I agree but here are my thoughts (and a bit of imagination):
First this is the result we expect for 2.0
http://www.flickr.com/photos/madhava_work/4993009605/in/set-72157624962763028/lightbox/

Once search suggestions (bug 586885) will be added to the browser the user will probably:
 * starts to type some letters
 * look at the awesome bar result and the search suggestions (if any)
 * if there is no results that pleased him the user will likely switch to an other search engines (for examples imagine a fake search engine added by an extension to search through your installed webapps)

The results will be a bit like what the Google bar does on Android.

But well, going back to reality and the current implementation we have. Showing the search engine list is more or less a final decision and it looks like there is no real need for the VKB. 
In the other hand the user stays on the same screen and has not asked to dismiss the VKB and can possibly decide to go back to add a letter or correct a mistake he has done.

What does our UX "Magic 8 ball" beltzner have in mind for us?

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Currently (including Fennec 2.0) using the search providers is a final decision (no more typing). This is even true with the cool looking theme changes you linked too.

The VKB must be hidden at this time. The is just not enough room for the provider list and the VKB, especially on Meego in landscape.

If the user wishes to dismiss the search provider panel and continue typing, they should be able to do that. Dismissing the search provider should set focus back to the end of the text in the URLbar. This would make the VKB appear again and typing could proceed.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

I agree with Mark; we should hide the VKB and then show the search provider list, getting rid of the jerkiness. Pressing Android Back should return focus to the awesomescreen location bar which would restore the VKB.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 478938 [details] [diff] [review]
Patch

Needs a new patch

Comment 11

[Matt Brubeck (:mbrubeck)]

This will work better with the new arrowbox search engine popup, but we need to make the contents of the arrowbox scrollable to handle large lists.

Comment 12

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Fixed by side effects and because the VKB should be dismissed finally

Comment 13

[Aakash Desai [:aakashd]]

verified FIXED on builds:
Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b8pre) Gecko/20101105 Namoroka/4.0b8pre Fennec/4.0b2pre

and

Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101105 Namoroka/4.0b8pre Fennec/4.0b2pre

Comment 14

[Aaron Train [:aaronmt]]

https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=13763