The default bug view has changed. See this FAQ.

Bump minimum required version for system NSS to 3.12.8

RESOLVED FIXED in mozilla2.0b7

Status

()

Core
Build Config
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Micah Gersten, Assigned: reed)

Tracking

Trunk
mozilla2.0b7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking2.0 final+, blocking1.9.2 .11+, status1.9.2 .11-fixed, blocking1.9.1 .14+, status1.9.1 .14-fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
/build/buildd/xulrunner-2.0-2.0~b7~hg20100926r54658+nobinonly/build-tree/mozilla/security/manager/ssl/src/nsNSSErrors.cpp:163: error: 'SSL_ERROR_WEAK_SERVER_EPHEMERAL_DH_KEY' was not declared in this scope
make[6]: *** [nsNSSErrors.o] Error 1

This was added here:
http://hg.mozilla.org/mozilla-central/rev/d04cc71e768b
to fix bug 587407

Is NSS 3.12.8 now required for mozilla-central?
(Reporter)

Updated

7 years ago
Summary: mozilla-central won't build with the system NSS 3.12.7 → mozilla-central won't build with system NSS 3.12.7

Comment 1

7 years ago
Micah: thank you for the bug report.  I expected to hear from you.

SSL_ERROR_WEAK_SERVER_EPHEMERAL_DH_KEY is new in NSS 3.12.8.  It
is not defined as a macro, so we can't use conditional compilation.

You can replace SSL_ERROR_WEAK_SERVER_EPHEMERAL_DH_KEY with its
value -12173, if you want to build with system NSS 3.12.7.  I
recommend requiring NSS 3.12.8.
(Reporter)

Comment 2

7 years ago
(In reply to comment #1)
> Micah: thank you for the bug report.  I expected to hear from you.
> 
> SSL_ERROR_WEAK_SERVER_EPHEMERAL_DH_KEY is new in NSS 3.12.8.  It
> is not defined as a macro, so we can't use conditional compilation.
> 
> You can replace SSL_ERROR_WEAK_SERVER_EPHEMERAL_DH_KEY with its
> value -12173, if you want to build with system NSS 3.12.7.  I
> recommend requiring NSS 3.12.8.

Should I move this to build config and propose bumping minimum NSS to 3.12.8?

Comment 3

7 years ago
That sounds good.

I'm still new to the minimum NSS requirement problem.
Do you usually want to avoid bumping the minimum NSS
version requirement?
(Assignee)

Updated

7 years ago
Blocks: 595300
No longer blocks: 587407
blocking1.9.1: --- → ?
blocking1.9.2: --- → ?
blocking2.0: --- → ?
status1.9.1: --- → ?
status1.9.2: --- → ?
Component: Security: PSM → Build Config
OS: Linux → All
QA Contact: psm → build-config
Summary: mozilla-central won't build with system NSS 3.12.7 → Bump minimum required NSS version to 3.12.8
(Assignee)

Updated

7 years ago
Summary: Bump minimum required NSS version to 3.12.8 → Bump minimum required version for system NSS to 3.12.8
(Assignee)

Comment 4

7 years ago
Created attachment 479206 [details] [diff] [review]
patch - v1
Assignee: nobody → reed
Status: NEW → ASSIGNED
Attachment #479206 - Flags: review?(wtc)
Attachment #479206 - Flags: approval2.0?
Attachment #479206 - Flags: approval1.9.2.11?
Attachment #479206 - Flags: approval1.9.1.14?

Updated

7 years ago
blocking1.9.1: ? → .14+
blocking1.9.2: ? → .11+
Attachment #479206 - Flags: review?(wtc) → review+

Updated

7 years ago
Attachment #479206 - Flags: approval1.9.2.11?
Attachment #479206 - Flags: approval1.9.2.11+
Attachment #479206 - Flags: approval1.9.1.14?
Attachment #479206 - Flags: approval1.9.1.14+

Comment 5

7 years ago
Comment on attachment 479206 [details] [diff] [review]
patch - v1

r=wtc.
Attachment #479206 - Flags: review+
(Assignee)

Comment 6

7 years ago
Comment on attachment 479206 [details] [diff] [review]
patch - v1

Branch blocker now, so don't need approval2.0
Attachment #479206 - Flags: approval2.0?
(Assignee)

Comment 7

7 years ago
http://hg.mozilla.org/mozilla-central/rev/8cd9614fdddf
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/c830268be12d
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/4c3ad5bc2afe
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
status1.9.1: ? → .14-fixed
status1.9.2: ? → .11-fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b7
Blocks: 587407
blocking2.0: ? → final+
You need to log in before you can comment on or make changes to this bug.