Don't check for noembed, iframe or noframes when running a script

RESOLVED FIXED in mozilla2.0b8

Status

()

Core
DOM
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: hsivonen, Assigned: Ms2ger)

Tracking

({dev-doc-complete, html5})

Trunk
mozilla2.0b8
dev-doc-complete, html5
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

See http://www.w3.org/Bugs/Public/show_bug.cgi?id=10522

Remove the use of InNonScriptingContainer() from nsScriptElement.cpp.
So do other browsers run script in those situations?
(In reply to comment #1)
> So do other browsers run script in those situations?

They (Opera 10.62, IE9 beta 1 and 6.0.472.63 beta) do.

http://hsivonen.iki.fi/test/moz/non-scripting-container.html
http://hsivonen.iki.fi/test/moz/non-scripting-container.xhtml
Ok, then we should be good.  Does this need to happen for 2.0, or is it Just A Bug?
(Assignee)

Updated

7 years ago
Assignee: nobody → Ms2ger
Status: NEW → ASSIGNED
(Assignee)

Comment 4

7 years ago
Created attachment 485399 [details] [diff] [review]
Run scripts inside noembed, iframe and noframes elements
(Assignee)

Comment 5

7 years ago
Created attachment 485406 [details] [diff] [review]
Run scripts inside noembed, iframe and noframes elements
(Assignee)

Updated

7 years ago
Attachment #485406 - Flags: review?(bzbarsky)
(Assignee)

Updated

7 years ago
Attachment #485399 - Attachment is obsolete: true
Attachment #485406 - Flags: review?(bzbarsky) → review+
Comment on attachment 485406 [details] [diff] [review]
Run scripts inside noembed, iframe and noframes elements

(In reply to comment #3)
> Ok, then we should be good.  Does this need to happen for 2.0, or is it Just A
> Bug?

I'm not aware of blocker-level impact, but now that a reviewed patch exists and the patch looks low-risk, it would nice to take it.
Attachment #485406 - Flags: approval2.0?

Updated

7 years ago
Attachment #485406 - Flags: approval2.0? → approval2.0+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
Landed: http://hg.mozilla.org/mozilla-central/rev/61700880b872
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Keywords: dev-doc-needed
(Assignee)

Comment 8

7 years ago
Added notes to

https://developer.mozilla.org/en/Firefox_4_for_developers
https://developer.mozilla.org/En/HTML/Element/Script

I'm assuming this is enough documentation for this little quirk.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.