600175 - Don't check for noembed, iframe or noframes when running a script

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Henri Sivonen (:hsivonen)]

See http://www.w3.org/Bugs/Public/show_bug.cgi?id=10522

Remove the use of InNonScriptingContainer() from nsScriptElement.cpp.

Comment 1

[Boris Zbarsky [:bzbarsky]]

So do other browsers run script in those situations?

Comment 2

[Henri Sivonen (:hsivonen)]

(In reply to comment #1)
> So do other browsers run script in those situations?

They (Opera 10.62, IE9 beta 1 and 6.0.472.63 beta) do.

http://hsivonen.iki.fi/test/moz/non-scripting-container.html
http://hsivonen.iki.fi/test/moz/non-scripting-container.xhtml

Comment 3

[Boris Zbarsky [:bzbarsky]]

Ok, then we should be good.  Does this need to happen for 2.0, or is it Just A Bug?

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Run scripts inside noembed, iframe and noframes elements

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Run scripts inside noembed, iframe and noframes elements

Comment 6

[Henri Sivonen (:hsivonen)]

Comment on attachment 485406 [details] [diff] [review]
Run scripts inside noembed, iframe and noframes elements

(In reply to comment #3)
> Ok, then we should be good.  Does this need to happen for 2.0, or is it Just A
> Bug?

I'm not aware of blocker-level impact, but now that a reviewed patch exists and the patch looks low-risk, it would nice to take it.

Comment 7

[Daniel Holbert [:dholbert]]

Landed: http://hg.mozilla.org/mozilla-central/rev/61700880b872

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Added notes to

https://developer.mozilla.org/en/Firefox_4_for_developers
https://developer.mozilla.org/En/HTML/Element/Script

I'm assuming this is enough documentation for this little quirk.