600189 - Minefield asks to prevent additional dialogs after showModalDialog, although they were not displayed

Status: RESOLVED WORKSFORME

(Core :: DOM: Core & HTML, defect, P5)

Description

[Christian Ascheberg]

User-Agent:       Mozilla/5.0 (Windows NT 6.0; rv:2.0b7pre) Gecko/20100927 Firefox/4.0b7pre
Build Identifier: 

Minefield prevents popups automatically, but asks to prevent additional dialogs after showModalDialog is called twice.
A website had this onunload, which was especially confusing (see testcase).
The dialog shown does not really give much information either.

Reproducible: Always

Steps to Reproduce:
1. open testcase
2. close testcase
Actual Results:  
page is closed immediately, Minefield shows "Confirm Dialog Preference"-dialog though

Expected Results:  
Minefield should not show that dialog (or in this case show it before the page is closed)

Comment 1

[Christian Ascheberg]

Attachment: testcase

Comment 2

[gadjo]

Confirming for Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b7pre) Gecko/20100928 Firefox/4.0b7pre
Try also opening the testcase in the same tab and then pressing "back" button - the page remains unchanged, Minefield shows "Confirm Dialog Preference" and moreover there is one more alert ("Minefield didn't allow for popups" or somethign like this) on the top of the page. After confirming Minefield goes back to the previous page

Comment 3

[Christian Ascheberg]

Attachment: testcase, onload

This testcase uses onload and is probably more common.
Clicking Cancel on the dialog only inreases the number of blocked popups.
I think the dialog should provide more detailed information.

Comment 4

[Jesse Ruderman]

Attachment: window.print testcase, onload

Comment 5

[Florian Bender]

I cannot reproduce this in Fx 28 on OS X 10.9 with the (first) attached testcase. Can you please recheck on your system?

I can reproduce the second and third testcase, though. For the print testcase, it always shows the print dialog regardless of which option I choose in the prompt.

Comment 6

[Christian Ascheberg]

(In reply to Florian Bender from comment #5)
> I cannot reproduce this in Fx 28 on OS X 10.9 with the (first) attached
> testcase. Can you please recheck on your system?
> 
> I can reproduce the second and third testcase, though. For the print
> testcase, it always shows the print dialog regardless of which option I
> choose in the prompt.

Yes, exactly the same for me on Win7 with latest nightly.

Just in case it might be helpful:
Last bad nightly (regarding first testcase): 2012-08-14
First good nightly: 2012-08-15
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=22288130fea2&tochange=86ee4deea55b

Comment 7

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.

Comment 8

[:Gijs (he/him)]

The showModalDialog API was disabled in Firefox 56 and removed later on. As a result, I believe this bug is no longer present in (more) recent versions of Firefox. Please reopen and needinfo me if you think this bug is still relevant.

Bugmail filter: showModalDialogClosure.