600202 - Saved HTTP Auth password does not show the 'Forget Password' action

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

When visiting websites that have saved passwords, the site menu should display the "Forget Password" action. This works fine for websites, but it does not work for HTTP Auth sites, like http://intranet.mozilla.org

If I visit http://intranet.mozilla.org, I get an HTTP Auth dialog, with the option to save my password with the password manager. If I do this, the next time I visit the site, I am shown the site without needing to log in. However, I can't remove the password using "Forget Password" since the action is not in the site menu.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Match realms

We are currently only matching null realms. Not sure if there was a reason for that, but this matches any.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 479167 [details] [diff] [review]
Match realms

Vivien might know about the null realms question. Lets get him to review. Looks good to me.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #1)
> Created attachment 479167 [details] [diff] [review]
> Match realms
> 
> We are currently only matching null realms. Not sure if there was a reason for
> that, but this matches any.

There is no particular reason, I've stupidly applied what is said in the .idl
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/passwordmgr/public/nsILoginManager.idl#186

Reading the comment (nsILoginManager.idl#191) I wonder if replacing null by "" means we will not have anymore the password entered into forms fields?
If yes we could use both and do 2 call to the findLogins function?

Comment 4

[Wesley Johnston (:wesj)]

I tested and forms seemed to work (i.e. I selected my username in the formhelper ui, and my password was automatically filled in). I've got no problem with checking twice though.

Comment 5

[Wesley Johnston (:wesj)]

Oops. should say, the "forget password" box showed up, and seemed to work. Filling in has nothing to do with this.

Comment 6

[Wesley Johnston (:wesj)]

Attachment: Alternative

Alternative lazy patch, concating both lists together.

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 479167 [details] [diff] [review]
Match realms

Imo, there is no need to concatenate lists if it works with "" instead of null.
But in this case I would appreciate a test to be sure platform does not regress us at some point.

Comment 8

[Wesley Johnston (:wesj)]

Attachment: Tests

Tests.

Looking into this, is there some reason we are not using LoginManager.countLogins in updateForgetPassword instead?

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #8)
> Created attachment 480299 [details] [diff] [review]
> Tests
> 
> Tests.
> 
> Looking into this, is there some reason we are not using
> LoginManager.countLogins in updateForgetPassword instead?

A quick look at the code don't show me any reason for not using it and potentially countLogins could be faster!

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 480299 [details] [diff] [review]
Tests

Thanks for the test

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 479216 [details] [diff] [review]
Alternative

let's use the first patch

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/0a354232e6df
http://hg.mozilla.org/mobile-browser/rev/714488ed4108

Comment 13

[Cristian Nicolae (:xti)]

After I've logged into bugzilla.mozilla.org, the Forget Password option was available for the Site Panel. I will mark this bug as verified fixed.

--
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110912
Firefox/9.0a1 Fennec/9.0a1
Device: Samsung Galaxy S
OS: Android 2.2