600209 - Sites does not have product controls

Status: VERIFIED FIXED

(Input :: General, defect, P1)

Description

[Aakash Desai [:aakashd]]

Steps to Reproduce:

1. Go to input.stage.mozilla.com/themes
2. Go to input.stage.mozilla.com/sites

Actual Results:
The Product and Version comboboxes are not seen on themes and sites, but is seen on the main feedback dashboard page.

Expected Results:
The Product and Version comboboxes are available on themes, sites and our main feedback dashboard page.

Comment 1

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

I wouldn't call this a regression.  Those pages don't currently have version selectors in production, which is why I assumed that we didn't need product / version selectors on those pages.  

We shouldn't try to squeeze this in for 1.8.  If it's a high priority, then we should do a minor 1.9 release first thing next week.

Comment 2

[Aakash Desai [:aakashd]]

Aye, you're right.

Comment 3

[Aakash Desai [:aakashd]]

As for this being a high priority, its not for now. If we receive a large amount of feedback that requires themes and sites, then we should have a minor release that includes this fix before 2.0.

Comment 4

[Aakash Desai [:aakashd]]

Yeah, we just missed this when adding the product comboboxes. After thinking about this for a bit, we should follow-up and have a release with just this fix. I'll take the timing and planning of the release after some responses on availability over the next 2 weeks from people.


Style Guides by chowse:
http://people.mozilla.com/~chowse/drop/mozilla.com/input/style/themes.html
http://people.mozilla.com/~chowse/drop/mozilla.com/input/style/sites.html

Also, I apologize for the milestone fudgery. I really should do this AFTER drinking tea in the morning.

Comment 5

[Michael Kurze [:michaelk]]

Something to keep in mind for sites: The generate_sites management command currently replaces all sites clusters everytime it is run. This is fine if we only generate stuff for the 7 days / current version, but very wasteful if we want to keep past versions (would run approx. 10x as long, > 2h). So we should keep versions generated in the past, and modify the import script to only replace the clusters for the current version rather than cleaning out the sites database before each run.

Comment 6

[Aakash Desai [:aakashd]]

Another thing to mention here is that if we add product controls, we should only show platforms associated to the products:

Firefox: osx, linux, win7, win vista and win xp
Mobile: maemo, android

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #5)
> Something to keep in mind for sites: The generate_sites management command
> currently replaces all sites clusters everytime it is run. This is fine if we
> only generate stuff for the 7 days / current version, but very wasteful if we
> want to keep past versions (would run approx. 10x as long, > 2h). So we should
> keep versions generated in the past, and modify the import script to only
> replace the clusters for the current version rather than cleaning out the sites
> database before each run.

Sounds like a spinoff bug to me; mind filing, Michael?

Comment 8

[Aakash Desai [:aakashd]]

Filed bug 601636 due to comment #6

Comment 9

[Michael Kurze [:michaelk]]

Added bug 601639 for comment #7

I guess we do not need to include platforms in the sites clusters. Instead the dashboard would just select clusters according to comment #6

Comment 10

[Michael Kurze [:michaelk]]

http://github.com/fwenzel/reporter/commit/f9c5381ce78c7de29c73dfcf7fa760b1e184d23d

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on http://input.stage.mozilla.com/en-US/sites and http://input.stage.mozilla.com/en-US/themes/.

Bug 602950 covers removing the "All" filter.

Comment 12

[Vishal Kamdar [:vish_moz]]

Added test cases to litmus, tc # 13698 & 13699.