Closed
Bug 600402
Opened 14 years ago
Closed 14 years ago
don't copy strings that are in the same compartment already
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | beta7+ |
People
(Reporter: gal, Assigned: gal)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(2 files)
|
1.37 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
|
1.59 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•14 years ago
|
Assignee: general → gal
|
|
Assignee | |
Comment 1•14 years ago
|
||
|
|
Assignee | |
Updated•14 years ago
|
Attachment #479228 -
Flags: review?(mrbkap)
|
||
Comment 2•14 years ago
|
||
Tryserver is green.
|
|
Assignee | |
Comment 3•14 years ago
|
||
Land it.
|
||
Updated•14 years ago
|
Attachment #479228 -
Flags: review?(mrbkap) → review+
|
||
Comment 4•14 years ago
|
||
Should JSCompartment::wrap also skip the copy for atomized strings that live in the default compartment?
|
|
Assignee | |
Comment 5•14 years ago
|
||
#4: that should be safe
|
|
Assignee | |
Comment 6•14 years ago
|
||
mhm, I wonder if our compartment assertions cover that probably. we will find out
|
|
Assignee | |
Comment 7•14 years ago
|
||
Also don't copy atoms. Gregor, can you try this?
|
||
Updated•14 years ago
|
blocking2.0: ? → beta7+
|
|
||
Updated•14 years ago
|
Version: 1.9.2 Branch → Trunk
|
|
||
Comment 8•14 years ago
|
||
Whiteboard: fixed-in-tracemonkey
|
|
||
Comment 9•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•