600406 - rollup event consuming behavior is non-deterministic

Status: RESOLVED WORKSFORME

(Core :: Widget: Cocoa, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

gConsumeRollupEvent in nsCocoaWindow.mm is not initialized, so whether or not we consume rollup events on Mac for a given popup is random, unless it's explicitly specified (via setConsumeRollupEvent).

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Actually, I may have misdiagnosed this. Initializing it doesn't seem to help - I still seem to see seemingly-random behavior. Need to investigate more.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

My test case is http://gavinsharp.com/tmp/geo.html . It triggers a popup notification, and clicking the link while the popup is up let's you see whether the event is consumed. If I reload and click continuously, I occasionally get the event consumed, and occasionally don't.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

When the event isn't consumed, ConsumeOutsideClicks() returns false because mConsumeRollupEvent == nsIPopupBoxObject::ROLLUP_NO_CONSUME.

When it is consumed, ConsumeOutsideClicks() returns true because (mConsumeRollupEvent == nsIPopupBoxObject::ROLLUP_DEFAULT), and none of the special cases are hit.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

It looks like rollups where the event is consumed are always preceded by rollups where we don't get into the if (shouldRollup) block in maybeRollup.

Comment 5

[Neil Deakin]

Some changes have been made to the rollup code recently for bug 701760 to is this still a problem? I cannot reproduce.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

I can't reproduce this anymore.