Media tests' indexed ogg file has invalid index

RESOLVED FIXED

Status

()

Core
Audio/Video
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: cpearce, Assigned: cpearce)

Tracking

Trunk
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
It turns out that the media mochitests' indexed ogg file has an invalid index. This was caused by a bug in OggIndex's decoder. I'd previously found the bug in Firefox's decoder, which is very similar to OggIndex's, but I must have forgotten to make the same fix to OggIndex.

Firefox's index-decoding code would detect that the index was corrupt, and discard the index, so we weren't actually testing the index decoding. I've fixed the file's index and pushed it to TryServer, and our tests still pass, while exercising the index decoding.
(Assignee)

Comment 1

8 years ago
Created attachment 479290 [details] [diff] [review]
Patch: Fix index in bug516323.indexed.ogv
Assignee: nobody → chris
Blocks: 600724
(Assignee)

Comment 2

8 years ago
http://hg.mozilla.org/mozilla-central/rev/f6dc94a7b560
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.