600495 - Searching by field ranges fails when chfieldto specified

Status: VERIFIED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Gervase Markham [:gerv]]

4.0: https://landfill.bugzilla.org/bugzilla-4.0-branch/buglist.cgi?chfieldto=2007-07-03&chfield=status_whiteboard&chfieldfrom=2007-07-01&chfieldvalue=nothingafds

=> One bug found.

Tip: https://landfill.bugzilla.org/bugzilla-tip/buglist.cgi?chfieldto=2007-07-03&chfield=status_whiteboard&chfieldfrom=2007-07-01&chfieldvalue=nothingafds

=> Zarro boogs.

This query picks out a change from many years ago, which is identical in the two databases. Removing chfieldto from the second URL shows up the bug (and another one, as it happens).

Comment 1

[Max Kanat-Alexander]

I actually just re-discovered this independently, and have a fix for it.

Comment 2

[Max Kanat-Alexander]

Attachment: v1

During refactoring, I added an optimization for chfieldto and chfieldfrom that added a delta_ts term into the SQL (which considerably speeds things up). However, logically that's only valid for chfieldfrom--there's no similar optimization that I can think of at the moment that's possible for chfieldto.

Comment 3

[Max Kanat-Alexander]

Attachment: v2

Oops, v1 included some extra code.

Comment 4

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified Bugzilla/Search.pm
Committed revision 7504.

Comment 5

[Gervase Markham [:gerv]]

There's still something wrong here (may be a different bug, perhaps):

https://landfill.bugzilla.org/bugzilla-tip/buglist.cgi?chfieldto=1980-07-03&bug_id=1&chfieldfrom=1980-07-04

This should return no bugs - the range of dates is empty, as well as both dates being well before any time the bug was changed. The problem still occurs even if chfieldto is after chfieldfrom:

https://landfill.bugzilla.org/bugzilla-tip/buglist.cgi?chfieldto=1980-07-06&bug_id=1&chfieldfrom=1980-07-04

Gerv

Comment 6

[Max Kanat-Alexander]

Ah, you're right.

If somebody doesn't specify a field value or a particular field that's changed, then the chfieldto parameter *does* need to check the delta_ts column.

Comment 7

[Max Kanat-Alexander]

Attachment: Fix chfieldto

This patch fixes chfieldto to work by itself, and also adds tests to xt/search.t to make sure that we don't regress this in the future.

Comment 8

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified Bugzilla/Search.pm
modified xt/lib/Bugzilla/Test/Search/FieldTestNormal.pm
Committed revision 7524.

Comment 9

[Gervase Markham [:gerv]]

Yes, the relevant bzapi tests now pass.

Gerv