Closed Bug 600540 Opened 9 years ago Closed 9 years ago

Disable raw video by default for Gecko 2

Categories

(Core :: Audio/Video, defect)

x86
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b7

People

(Reporter: khuey, Assigned: khuey)

Details

Attachments

(1 file, 1 obsolete file)

Camera no longer blocks Fennec 4, so raw video has no consumers.  We should turn it off; there's no point in shipping code that we're not using and that just increases our attack surface.
Attached patch Patch (obsolete) — Splinter Review
Assignee: nobody → khuey
Status: NEW → ASSIGNED
Attachment #479385 - Flags: review?(chris)
Attached patch Patch 2Splinter Review
Need this too.
Attachment #479385 - Attachment is obsolete: true
Attachment #479388 - Flags: review?(chris)
Attachment #479385 - Flags: review?(chris)
Comment on attachment 479388 [details] [diff] [review]
Patch 2

No need to comment out the seek.yuv entry in content/media/test/manifest.js; its type should be unsupported with raw not enabled, so we shouldn't try to play it anyway.
Attachment #479388 - Flags: review?(chris) → review+
Comment on attachment 479388 [details] [diff] [review]
Patch 2

We should approve this for the reasons listed in comment 0.
Attachment #479388 - Flags: approval2.0?
Comment on attachment 479388 [details] [diff] [review]
Patch 2

a=beltzner
Attachment #479388 - Flags: approval2.0? → approval2.0+
Removed the commented test and ifdefed the mime type handler stuff just like the webm stuff is.

http://hg.mozilla.org/mozilla-central/rev/a701d821ef36
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
This didn't actually work because there is a MOZ_RAW=1 earlier in the file.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
http://hg.mozilla.org/mozilla-central/rev/5911688ed38a
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in before you can comment on or make changes to this bug.