Closed Bug 600642 Opened 9 years ago Closed 9 years ago

Proxy enumerateOwn trap should be renamed to keys

Categories

(Core :: JavaScript Engine, defect, P2)

x86
macOS
defect

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: tomvc.be, Assigned: gal)

Details

(Whiteboard: softblocker, fixed-in-tracemonkey)

Attachments

(1 file)

Object.keys(proxy) should call the 'keys' trap on the proxy handler (this trap used to be called 'enumerateOwn')
Priority: -- → P2
Attached patch patchSplinter Review
Assignee: general → gal
Attachment #479500 - Flags: review?(jorendorff)
blocking2.0: --- → ?
please add tests for these.
There are tests on hg.ecmascript.org, IIRC, but are they both up-to-date and integrated into jsreftests?

/be
Attachment #479500 - Flags: review+
Attachment #479500 - Flags: review?(jorendorff) → review+
blocking2.0: ? → final+
Looks like we have a good patch for this but it hasn't landed.
Keywords: checkin-needed
Andreas, can you land this patch this week?

/be
Will do.
blocking2.0: final+ → beta9+
Whiteboard: softblocker
As per today's meeting, beta 9 will be a time-based release. Marking these all betaN+. Please move it back to beta9+ if  you believe it MUST be in the next beta (ie: trunk is in an unshippable state without this)
blocking2.0: beta9+ → betaN+
http://hg.mozilla.org/tracemonkey/rev/9074de2454dc
Keywords: checkin-needed
Whiteboard: softblocker → softblocker, fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/9074de2454dc
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.