Closed Bug 600642 Opened 9 years ago Closed 9 years ago
Own trap should be renamed to keys
Object.keys(proxy) should call the 'keys' trap on the proxy handler (this trap used to be called 'enumerateOwn')
Assignee: general → gal
please add tests for these.
There are tests on hg.ecmascript.org, IIRC, but are they both up-to-date and integrated into jsreftests? /be
Don't know about integration into jsreftests, but the tests on hg.ecmascript.org should be up-to-date. The following tests in particular test the keys() trap: http://hg.ecmascript.org/tests/harmony/file/2aefb70cc024/proxies/TestCases/trap-arguments/keys.js http://hg.ecmascript.org/tests/harmony/file/2aefb70cc024/proxies/TestCases/doublelifting/keys.js http://hg.ecmascript.org/tests/harmony/file/2aefb70cc024/proxies/TestCases/duplicate-keys.js http://hg.ecmascript.org/tests/harmony/file/2aefb70cc024/proxies/TestCases/trap-throws/keys.js
Attachment #479500 - Flags: review?(jorendorff) → review+
Looks like we have a good patch for this but it hasn't landed.
Andreas, can you land this patch this week? /be
blocking2.0: final+ → beta9+
As per today's meeting, beta 9 will be a time-based release. Marking these all betaN+. Please move it back to beta9+ if you believe it MUST be in the next beta (ie: trunk is in an unshippable state without this)
blocking2.0: beta9+ → betaN+
Whiteboard: softblocker → softblocker, fixed-in-tracemonkey
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.