600642 - Proxy enumerateOwn trap should be renamed to keys

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P2)

Description

[Tom Van Cutsem]

Object.keys(proxy) should call the 'keys' trap on the proxy handler (this trap used to be called 'enumerateOwn')

Comment 1

[Andreas Gal :gal]

Attachment: patch

Comment 2

[Robert Sayre]

please add tests for these.

Comment 3

[Brendan Eich [:brendan]]

There are tests on hg.ecmascript.org, IIRC, but are they both up-to-date and integrated into jsreftests?

/be

Comment 4

[Tom Van Cutsem]

Don't know about integration into jsreftests, but the tests on hg.ecmascript.org should be up-to-date. The following tests in particular test the keys() trap:

http://hg.ecmascript.org/tests/harmony/file/2aefb70cc024/proxies/TestCases/trap-arguments/keys.js
http://hg.ecmascript.org/tests/harmony/file/2aefb70cc024/proxies/TestCases/doublelifting/keys.js
http://hg.ecmascript.org/tests/harmony/file/2aefb70cc024/proxies/TestCases/duplicate-keys.js
http://hg.ecmascript.org/tests/harmony/file/2aefb70cc024/proxies/TestCases/trap-throws/keys.js

Comment 5

[David Mandelin [:dmandelin]]

Looks like we have a good patch for this but it hasn't landed.

Comment 6

[Brendan Eich [:brendan]]

Andreas, can you land this patch this week?

/be

Comment 7

[Andreas Gal :gal]

Will do.

Comment 8

[LegNeato]

As per today's meeting, beta 9 will be a time-based release. Marking these all betaN+. Please move it back to beta9+ if  you believe it MUST be in the next beta (ie: trunk is in an unshippable state without this)

Comment 9

[Andreas Gal :gal]

http://hg.mozilla.org/tracemonkey/rev/9074de2454dc

Comment 10

[Chris Leary [:cdleary] (not checking bugmail)]

http://hg.mozilla.org/mozilla-central/rev/9074de2454dc