favicon from previous location persists until new page finishes loading

RESOLVED INVALID

Status

()

Firefox
Tabbed Browser
RESOLVED INVALID
8 years ago
8 years ago

People

(Reporter: Margaret, Assigned: Margaret)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(blocking2.0 beta8+)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

8 years ago
Created attachment 479661 [details]
favicon from previous location is still showing

After bug 597673 landed, we stopped hiding the favicon while the tab is busy, but we don't update the favicon until the page finishes loading. 

When we fix this we should try to find a way to avoid clearing the icon for same-host location changes, or at least page refreshes/reloads.
(Assignee)

Updated

8 years ago
Assignee: nobody → margaret.leibovic
(In reply to comment #0)
> After bug 597673 landed, we stopped hiding the favicon while the tab is busy,
> but we don't update the favicon until the page finishes loading.

We update the favicon as soon as we get a new one -- the exact point actually depends on the site.

> When we fix this we should try to find a way to avoid clearing the icon for
> same-host location changes, or at least page refreshes/reloads.

Ideally we would also avoid clearing the icon when the new one would be available shortly after.
blocking2.0: --- → beta8+
(Assignee)

Comment 2

8 years ago
Created attachment 481053 [details] [diff] [review]
patch

This patch immediately fades out the old favicon on location change and then replaces it with the blank page icon after a delay.
Attachment #481053 - Flags: review?(dao)
(Assignee)

Comment 3

8 years ago
Created attachment 481056 [details] [diff] [review]
patch v2

Oops, I forgot a line.
Attachment #481053 - Attachment is obsolete: true
Attachment #481056 - Flags: review?(dao)
Attachment #481053 - Flags: review?(dao)
(Assignee)

Comment 4

8 years ago
Bug 602964 makes this invalid.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → INVALID
(Assignee)

Updated

8 years ago
Attachment #481056 - Flags: review?(dao)
You need to log in before you can comment on or make changes to this bug.