600756 - favicon from previous location persists until new page finishes loading

Status: RESOLVED INVALID

(Firefox :: Tabbed Browser, defect)

Description

[:Margaret Leibovic]

Attachment: favicon from previous location is still showing

After bug 597673 landed, we stopped hiding the favicon while the tab is busy, but we don't update the favicon until the page finishes loading. 

When we fix this we should try to find a way to avoid clearing the icon for same-host location changes, or at least page refreshes/reloads.

Comment 1

[Dão Gottwald [:dao]]

(In reply to comment #0)
> After bug 597673 landed, we stopped hiding the favicon while the tab is busy,
> but we don't update the favicon until the page finishes loading.

We update the favicon as soon as we get a new one -- the exact point actually depends on the site.

> When we fix this we should try to find a way to avoid clearing the icon for
> same-host location changes, or at least page refreshes/reloads.

Ideally we would also avoid clearing the icon when the new one would be available shortly after.

Comment 2

[:Margaret Leibovic]

Attachment: patch

This patch immediately fades out the old favicon on location change and then replaces it with the blank page icon after a delay.

Comment 3

[:Margaret Leibovic]

Attachment: patch v2

Oops, I forgot a line.

Comment 4

[:Margaret Leibovic]

Bug 602964 makes this invalid.