600821 - font used for IVS reftest is rejected by the sanitizer

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Jonathan Kew [:jfkthame]]

The downloadable font "gw432047.ttf" used in layout/reftests/font-face/ivs-1.html (for bug 552460) is rejected by the OTS sanitizer library, which will cause this reftest to fail (unless it happens to fall back to a platform font that supports the IVS codes being used) once the sanitizer is enabled.

We need to identify the anomaly in the font that is causing it to be rejected, and fix this so that we can resume testing IVS support.

Comment 1

[Jonathan Kew [:jfkthame]]

This font is rejected because the final table in the font is not padded to a 4-byte boundary.

(The OpenType specification is not entirely explicit about whether such padding is required, though there is at least an implication that it should be present. There have been some tools in the past that generated unpadded fonts, but current tools and reading of the spec seem to be converging on the use of padding in all cases.)

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: patch, v1 - add proper padding to the gw432047.ttf font

This simply adds the two NUL bytes required for proper padding at the end of the file; the sanitizer is then happy to accept the font.

Comment 3

[Jonathan Kew [:jfkthame]]

http://hg.mozilla.org/mozilla-central/rev/b5a712056df5