600862 - Clicking "Learn More" button in Add-ons Manager results in going to ebay.com

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aakash Desai [:aakashd]]

Build Id:
Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b6pre) Gecko/20100930 Namoroka/4.0b7pre Fennec/4.0b1pre

and

Mozilla/5.0 (Android; Linux armv71; rv:2.0b6pre) Gecko/20100930 Namoroka/4.0b7pre Fennec/4.0b1pre


Steps to Reproduce:
1. Swipe to the left to open the controls sidebar
2. Click on the browser controls button
3. Click on the Add-ons Manager pane button
4. Pan down to the "Whats an Addon" row entry" and tap on it.
5. Click on the "Learn More" button

Actual Results:
I go to http://ebay.com/

Expected Results:
I'm guessing a discovery page for add-ons on AMO

Comment 1

[Aakash Desai [:aakashd]]

Uh, I think this should definitely be a b1 blocker

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #1)
> Uh, I think this should definitely be a b1 blocker

Why, the feature is not in b1?

Comment 3

[Aakash Desai [:aakashd]]

Right, never mind. This branching stuff without nightlies is confusing.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Uses the same URL Firefox does. The web page currently doesn't have the "What are Add-ons" section at the top. We can figure that out later.

Comment 5

[Matt Brubeck (:mbrubeck)]

Comment on attachment 479930 [details] [diff] [review]
patch

The change is fine, but it makes me wonder why we have two buttons right next to each other that go to the same URL.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #5)
> Comment on attachment 479930 [details] [diff] [review]
> patch
> 
> The change is fine, but it makes me wonder why we have two buttons right next
> to each other that go to the same URL.

The buttons should be in separate rows, with some add-ons in between them. However, it's a good question even if there are 5 add-ons in between the buttons.

We'll see how this evolves. I'll file a bug for taking it to the next level - whatever that level may be.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/852ff9afa2ff

Filed bug 601044 for polishing the rough edges

Comment 8

[Aakash Desai [:aakashd]]

verified FIXED on builds:
Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b7pre) Gecko/20101001 Namoroka/4.0b7pre Fennec/4.0b2pre

and

Mozilla/5.0 (Android; Linux armv71; rv:2.0b7pre) Gecko/20101001 Namoroka/4.0b7pre Fennec/4.0b2pre