600900 - [clang]: cannot initialize a parameter of type 'NSString *' with an lvalue of type 'NSString const in nsDragService.mm

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Nomis101]

Attachment: nsDragService.mii

nsDragService.mm doesn't build with Clang because of:


/Volumes/Developer/temp-clang/src/mozilla/widget/src/cocoa/nsDragService.mm:421:59: error: 
      cannot initialize a parameter of type 'NSString *' with an lvalue of type
      'NSString const *'
      NSString* pString = [globalDragPboard stringForType:pboardType];
                                                          ^~~~~~~~~~
In file included from /Volumes/Developer/temp-clang/src/mozilla/widget/src/cocoa/nsDragService.mm:44:
In file included from /Volumes/Developer/temp-clang/src/mozilla/widget/src/cocoa/nsDragService.h:44:
In file included from /Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/Cocoa.framework/Headers/Cocoa.h:13:
In file included from /Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/AppKit.framework/Headers/AppKit.h:36:
In file included from /Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSColor.h:32:
/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSPasteboard.h:138:41: note: 
      passing argument to parameter 'dataType' here
- (NSString *)stringForType:(NSString *)dataType;
                                        ^
/Volumes/Developer/temp-clang/src/mozilla/widget/src/cocoa/nsDragService.mm:531:57: error: 
      cannot initialize a parameter of type 'NSString *' with an lvalue of type
      'NSString const *'
    if (availableType && [availableType isEqualToString:pboardType])
                                                        ^~~~~~~~~~
In file included from /Volumes/Developer/temp-clang/src/mozilla/widget/src/cocoa/nsDragService.mm:44:

Comment 1

[Scott Greenlay [:sgreenlay]]

Depends on changes in nsClipboard::IsStringType (583460)

Comment 2

[Scott Greenlay [:sgreenlay]]

Attachment: Drag Service Patch (v1.0)

Changed const NSString * to NSString * (matches changes to nsClipboard::IsStringType in 583460).

Builds under standard build system, please test under clang.

Comment 3

[Nomis101]

This also builds with Clang, I don't get the errors anymore with this patch (tested only with Apples Clang, because there seems to be a strange compiler Bug in current Clang trunk).

Comment 4

[Scott Greenlay [:sgreenlay]]

Attachment: Drag Service Patch (v1.0) - commit message

Comment 5

[Josh Aas]

pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/0fab20410b0a