points.initialize causes nsDocument leak and "ABORT: Tear-off objects remain in hashtable at shutdown"

RESOLVED WORKSFORME

Status

()

Core
SVG
--
critical
RESOLVED WORKSFORME
8 years ago
8 years ago

People

(Reporter: Jesse Ruderman, Unassigned)

Tracking

(Blocks: 1 bug, {assertion, memory-leak, testcase})

Trunk
x86
Mac OS X
assertion, memory-leak, testcase
Points:
---

Firefox Tracking Flags

(blocking2.0 final+)

Details

Attachments

(3 attachments)

(Reporter)

Description

8 years ago
Created attachment 479869 [details]
leaking testcase (requires extension; quits Firefox when loaded)

1. Temporarily install 'DOM Fuzz Lite' from
    https://www.squarefree.com/extensions/domFuzzLite.xpi
2. Load one of the testcases.

Result: leak nsDocument / abort
(Reporter)

Comment 1

8 years ago
Created attachment 479870 [details]
ABORT testcase (requires extension; quits Firefox when loaded)
(Reporter)

Comment 2

8 years ago
Created attachment 479871 [details]
stack trace for the abort

###!!! ABORT: Tear-off objects remain in hashtable at shutdown.: 'mTable.Count() == 0', file content/svg/content/src/nsSVGAttrTearoffTable.h, line 54

At nsSVGAttrTearoffTable<nsSVGLength2, nsIDOMSVGAnimatedLength>::
  ~nsSVGAttrTearoffTable()

Updated

8 years ago
Blocks: 515116
blocking2.0: --- → final+

Updated

8 years ago
No longer blocks: 515116
blocking2.0: final+ → ---
(Reporter)

Comment 3

8 years ago
The line
  x.points.initialize({})

now triggers
  Error: uncaught exception: [Exception... "Unknown or invalid type"  code: "0" nsresult: "0x80620000 (NS_ERROR_DOM_SVG_WRONG_TYPE_ERR)"  location: "file:///Users/jruderman/Desktop/s.svg Line: 14"]
(Reporter)

Comment 4

8 years ago
... thanks to the fix for bug 601251.
(Reporter)

Comment 5

8 years ago
Did that fix the leak bug, or just break the testcase?
(Reporter)

Updated

8 years ago
blocking2.0: --- → ?
It stopped you being able to pass random weird things to most SVG DOM methods. The leak may well no longer be triggerable.
You'll have to try harder from now on ;-)
(Reporter)

Comment 8

8 years ago
Fair enough ;)
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → WORKSFORME
blocking2.0: ? → final+
You need to log in before you can comment on or make changes to this bug.