600970 - Serializer shouldn't update all its states when it is serializing for raw, non-formatter output.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

RFind can be slow.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: wip

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 479923 [details] [diff] [review]
wip

Passes tryserver.
And I couldn't see any code which uses 
mIsIndentationAddedOnCurrentLine or mColPos when 
mDoRaw is true.

Comment 3

[Laurent Jouanneau]

Comment on attachment 479923 [details] [diff] [review]
wip

Ok for me. 

During the review, I found two lines of code duplicated in the same method, in Init(), line 119 and 159 

mIsIndentationAddedOnCurrentLine = PR_FALSE;

One is enough :-) Could you remove one of them before you commit ?

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/07a8287b4cc9

Sorry didn't remove that line.