Closed Bug 600970 Opened 12 years ago Closed 12 years ago

Serializer shouldn't update all its states when it is serializing for raw, non-formatter output.

Categories

(Core :: DOM: Core & HTML, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: smaug, Assigned: smaug)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

RFind can be slow.
Attached patch wipSplinter Review
Comment on attachment 479923 [details] [diff] [review]
wip

Passes tryserver.
And I couldn't see any code which uses 
mIsIndentationAddedOnCurrentLine or mColPos when 
mDoRaw is true.
Attachment #479923 - Flags: review?(laurent)
Comment on attachment 479923 [details] [diff] [review]
wip

Ok for me. 

During the review, I found two lines of code duplicated in the same method, in Init(), line 119 and 159 

mIsIndentationAddedOnCurrentLine = PR_FALSE;

One is enough :-) Could you remove one of them before you commit ?
Attachment #479923 - Flags: review?(laurent) → review+
Attachment #479923 - Flags: approval2.0?
Attachment #479923 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/07a8287b4cc9

Sorry didn't remove that line.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.