Closed Bug 600993 Opened 9 years ago Closed 9 years ago

tab sync no longer has any reason to ever touch disk

Categories

(Firefox :: Sync, defect)

x86
Windows Vista
defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: mconnor, Assigned: philikon)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

We can recreate data from the sessionstore API if needed, and bug 600991 should mean that for most users the ordering data is entirely irrelevant, so we can just sync all tabs, in the order of the window.  We should just special-case tabs to keep a score, but not changedIDs, and grab the current tab set when it's time to sync, and make sure it never saves JSON to disk.
blocking2.0: --- → betaN+
Blocks: 608617
Blocks: 609395
(In reply to comment #0)
> We can recreate data from the sessionstore API if needed, and bug 600991 should
> mean that for most users the ordering data is entirely irrelevant, so we can
> just sync all tabs, in the order of the window.

I'm not sure what that has to do with disk I/O.

> We should just special-case
> tabs to keep a score, but not changedIDs, and grab the current tab set when
> it's time to sync, and make sure it never saves JSON to disk.

Indeed. Patch coming up!
Attached patch v1Splinter Review
Assignee: nobody → philipp
Attachment #489409 - Flags: review?(mconnor)
Comment on attachment 489409 [details] [diff] [review]
v1

This works, though I'm waffling on .modified as a "public" value.  Either way works, it's not like it's really public/not public.
Attachment #489409 - Flags: review?(mconnor) → review+
http://hg.mozilla.org/services/fx-sync/rev/1919d9d6bfb7
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Blocks: 612381
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.