601099 - reference font used for reftest "load-badchecksum.html" is rejected by OTS sanitizer

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Jonathan Kew [:jfkthame]]

The "good" reference font VeraBd-validchecksum.ttf, used by layout/reftests/font-face/load-badchecksum.html, is rejected by the OTS sanitizer. According to Apple's (not-very-thorough) ftxvalidator tool, there's a problem with the 'name' table.

Because this reference font is rejected, the reftest no longer works as intended once the sanitizer is deployed.

Comment 1

[Jonathan Kew [:jfkthame]]

This font is being rejected by the sanitizer because the final table in the font is not padded to a 4-byte boundary.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: patch, v1 - add proper padding to the VeraBd-validchecksum.ttf font file

Comment 3

[Jonathan Kew [:jfkthame]]

http://hg.mozilla.org/mozilla-central/rev/c1e91a637f57

Comment 4

[Jonathan Kew [:jfkthame]]

Comment on attachment 480278 [details] [diff] [review]
patch, v1 - add proper padding to the VeraBd-validchecksum.ttf font file

Requesting approval for 1.9.2.13. This is a test-only patch, fixing an error in one of the test fonts we use; we need to fix this on branch, otherwise landing bug 527276 will lead to reftest failures because the incorrect font will no longer be loaded.

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 480278 [details] [diff] [review]
patch, v1 - add proper padding to the VeraBd-validchecksum.ttf font file

Approved for 1.9.2.13, a=dveditz for release-drivers

Comment 6

[Jonathan Kew [:jfkthame]]

Pushed to 1.9.2:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/df5318538e6e

Comment 7

[Jonathan Kew [:jfkthame]]

Comment on attachment 480278 [details] [diff] [review]
patch, v1 - add proper padding to the VeraBd-validchecksum.ttf font file

Requesting approval to land on 1.9.1, so that we can take the OTS font sanitizer there.

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 480278 [details] [diff] [review]
patch, v1 - add proper padding to the VeraBd-validchecksum.ttf font file

Approved for 1.9.1.16, a=dveditz for release-drivers

Comment 9

[Jonathan Kew [:jfkthame]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/f404e712baaa