The default bug view has changed. See this FAQ.

OTF-CFF versions of font markA used in reftests are rejected by the OTS sanitizer

RESOLVED FIXED

Status

()

Core
Layout: Text
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: jfkthame, Assigned: jfkthame)

Tracking

unspecified
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(status1.9.2 .13-fixed, status1.9.1 .16-fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
The font markA.otf and (I think) markB.otf, used by a couple of the files in layout/reftests/font-face (download-2-big-otf.html and src-list-2-big-otf.html) appear to be rejected by the OTS sanitizer, causing these tests to fail.
(Assignee)

Updated

7 years ago
Blocks: 527276
(Assignee)

Comment 1

7 years ago
The problem with markA.otf and markB.otf is that the usFirstCharIndex and usLastCharIndex fields in the OS/2 table are incorrect: in both fonts, these two fields are set to 0xFFFF and 0x0000 respectively. This is illegal (firstChar > lastChar), so OTS rejects the fonts.

The .ttf versions of these fonts have the correct values here. I guess the conversion to .otf must have been done with a version of FontForge that rewrote this table incorrectly.
(Assignee)

Comment 2

7 years ago
Created attachment 480268 [details] [diff] [review]
patch, v1 - fix OS/2 table in markA.otf and markB.otf

This fixes the firstCharIndex and lastCharIndex fields in the OS/2 tables such that the sanitizer no longer rejects the fonts.
Assignee: nobody → jfkthame
Attachment #480268 - Flags: review?(jdaggett)

Comment 3

7 years ago
Just for reference, does the latest version of FontForge generate this correctly?

Updated

7 years ago
Attachment #480268 - Flags: review?(jdaggett) → review+
(Assignee)

Comment 4

7 years ago
I have a version from Sept 2009 installed here, and just tried opening MarkA.ttf and generating MarkA.otf using this; the resulting font had correct first/lastCharIndex fields in the OS/2 table. So it looks like this got fixed at some point (assuming it was a fontforge bug that originally led to the bad fonts).
(Assignee)

Comment 5

7 years ago
http://hg.mozilla.org/mozilla-central/rev/2583274ff9fc
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

7 years ago
Comment on attachment 480268 [details] [diff] [review]
patch, v1 - fix OS/2 table in markA.otf and markB.otf

Requesting approval for 1.9.2.13. This is a test-only patch, fixing an error in a couple of the test fonts we use; we need to fix this on branch, otherwise landing bug 527276 will lead to reftest failures because the incorrect fonts will no longer be loaded.
Attachment #480268 - Flags: approval1.9.2.13?
Comment on attachment 480268 [details] [diff] [review]
patch, v1 - fix OS/2 table in markA.otf and markB.otf

Approved for 1.9.2.13, a=dveditz for release-drivers
Attachment #480268 - Flags: approval1.9.2.13? → approval1.9.2.13+
(Assignee)

Comment 8

7 years ago
Pushed to 1.9.2:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/d48042220ae0
status1.9.2: --- → .13-fixed
(Assignee)

Comment 9

6 years ago
Comment on attachment 480268 [details] [diff] [review]
patch, v1 - fix OS/2 table in markA.otf and markB.otf

Requesting approval to land on 1.9.1, so that we can take the OTS font sanitizer there.
Attachment #480268 - Flags: approval1.9.1.16?
Comment on attachment 480268 [details] [diff] [review]
patch, v1 - fix OS/2 table in markA.otf and markB.otf

Approved for 1.9.1.16, a=dveditz for release-drivers
Attachment #480268 - Flags: approval1.9.1.16? → approval1.9.1.16+
(Assignee)

Comment 11

6 years ago
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/8982331bf83b
status1.9.1: --- → .16-fixed
You need to log in before you can comment on or make changes to this bug.