Closed Bug 601185 Opened 9 years ago Closed 9 years ago

Ensure plugins are globally enabled when running xpcshell tests (m-1.9.2 branch)

Categories

(Core :: Plug-ins, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
status1.9.2 --- .13-fixed
status1.9.1 --- unaffected

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Attached patch The fixSplinter Review
In bug 599119, we took the decision to globally disable plugins in Thunderbird due to performance issues - this is just on the 1.9.2 branch, trunk is getting a different fix so that we'll get better testing on it before it goes out in the wild.

Unfortunately this has now broken some of the xpcshell-tests which expect plugins to be enabled.

I'd therefore like to land a couple of changes on mozilla-1.9.2 to fix the broken xpcshell-tests - simply to set the preference to ensure that plugins are not disabled; then the tests can run successfully for everyone.

If we want to land this on trunk as well, then I'm happy to do that.

gavin, would you mind doing a review on this?
Attachment #480166 - Flags: review?(gavin.sharp)
Assignee: nobody → bugzilla
Attachment #480166 - Flags: review?(gavin.sharp) → review+
Checked into 1.9.2: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/334ef251eddd

This is a test-only fix. I'm not planning on landing on trunk unless anyone particularly wants it there (as mentioned in comment 0).
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.