601196 - Console styling busted by personas

Status: VERIFIED FIXED

(DevTools :: General, defect, P1)

Description

[Johnathan Nightingale [:johnath]]

Attachment: Console with white text

See attached screenshot - this persona's colour choices make the javascript console interactions invisible, since the text is white-on-white (selected in the screenshot just to make it visible). The white text on checkboxes also doesn't look good.

The choice of persona should not ever render the console unusable.

Comment 1

[David Dahl :ddahl]

this is the second bug like this, see bug 573840

I am amazed that the personas CSS code is so global. The console CSS is very targeted, I would assume the personas CSS should also do the same.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Personas affect the entire browser window, so all main-window elements need to be aware of them. I think you probably need some :-moz-lwtheme-brighttext selectors in this case.

Comment 3

[David Dahl :ddahl]

(In reply to comment #2)
> Personas affect the entire browser window, so all main-window elements need to
> be aware of them. I think you probably need some :-moz-lwtheme-brighttext
> selectors in this case.

Ah, so in that case, can we use lightweight themes to create themes for the console?

Comment 4

[Dão Gottwald [:dao]]

(In reply to comment #3)
> (In reply to comment #2)
> > Personas affect the entire browser window, so all main-window elements need to
> > be aware of them. I think you probably need some :-moz-lwtheme-brighttext
> > selectors in this case.
> 
> Ah, so in that case, can we use lightweight themes to create themes for the
> console?

I don't think you want that. You should just stop the text color inheritance together with the text shadow.

Comment 5

[Patrick Walton (:pcwalton)]

This seems to be fixed in the patches for bug 601667.

Comment 6

[Kevin Dangoor]

mass change: filter on PRIORITYSETTING

Comment 7

[Kevin Dangoor]

mass change: filter on PRIORITYSETTING

Comment 8

[Kevin Dangoor]

mass change: filter mail on BLOCKERSETTING

Comment 9

[Kevin Dangoor]

We should confirm if this is fixed now that bug 601667 has landed.

Comment 10

[Rob Campbell [:rc] (:robcee)]

it is not :(

Comment 11

[Patrick Walton (:pcwalton)]

This seems to be fixed in the patches to bug 605621.

Comment 12

[Rob Campbell [:rc] (:robcee)]

white text from personas no longer obscures the text in the console, so I'm marking this fixed. Courtesy of bug 605621.

Comment 13

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Verified on Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b10) Gecko/20100101 Firefox/4.0b10 ID:20110121161344