601198 - Windows with pinned tabs being automatically restored at browser start up if crash recovery is disabled (also restores non-pinned tabs)

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect)

Description

[Michael Kraft [:morac]]

Steps to reproduce:

1. Set browser.sessionstore.resume_from_crash to false
2. Set browser.startup.page to 0  (blank tab)
3. Open any number of windows and tabs.
4. Pin one of the tabs.
5. Wait for sesionstore.js to be updated.
6. Exit Firefox.
7. Run Firefox.

Expected result:

1. One window with a blank tab.  Previous session should be available for restore from History tool menu.

Actual results:

1. The active window at browser shutdown is automatically restored in it's entirety (all pinned and non-pinned tabs.  For all other windows that were open at shutdown, only the pinned tabs are restored.  Windows with that had no pinned tabs are opened with just a blank tab.


Cause:

As of bug 580512 landing, saveState sets "sessionstore.resume_session_once" preference if "browser.sessionstore.resume_from_crash" is false and there are (or has ever been) pinned tabs.  This triggers SessionStart to set the sessionType to "RESUME_SESSION" the next time Firefox is start.

Based on my understanding of bug 580512, app tabs should only be restored on a crash and only the app tabs, not all the tabs.  Neither is the case here though.

After shutdown, sessionstore.js actually contains all windows and tabs (pinned and non-pinned).  The reason only the active window has all it's tabs restored and the other tabs only have their app tabs restored is because of bug 601161.

Comment 1

[Marcia Knous [:marcia]]

Dupe of Bug 600545?

Comment 2

[Marcia Knous [:marcia]]

NM, I see you filed this bug as a result of Bug 600545 Comment 15.

Comment 3

[Michael Kraft [:morac]]

I have a fix for this which appears to be working.  I'll either put it here or fix it under bug 600545.

Comment 4

[Michael Kraft [:morac]]

The patch to bug 600545 fixes this bug.

Comment 5

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Bug 600545 was resolved with http://hg.mozilla.org/mozilla-central/rev/9bb000fc3c3a