601204 - [VKB] Fennec is not responsive to system context menu for landscape keyboard

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[Aakash Desai [:aakashd]]

Build Id:
Mozilla/5.0 (Android; Linux armv71; rv:2.0b7pre) Gecko/20101001 Namoroka/4.0b7pre Fennec/4.0b2pre

Steps to Reproduce:
1. Go to bugzilla.mozilla.org
2. Tap on the search field
3. Type in "mozilla" into the search field
4. Switch to landscape orientation
5. Long tap on the landscape soft kb's text field
6. Select "Select All"

Actual Results:
The text is not highlighted

Expected Results:
The text is highlighted
Expected Results

Comment 1

[Brian Crowder]

Alright, getting a pretty good grip on this now, thanks to some hints from jchen.  I'll try to have a patch implementing selectAll and some others tomorrow.

Comment 2

[Brian Crowder]

Attachment: Implement performContextMenuAction

We must implement this override if our intention is to provide our own text editor, which is basically what we're doing.

This patch does not currently attempt to implement selection modes ("Select Text", "Stop Selecting Text"), which I guess we can tackle in a follow-up bug.  That's harder to fix, though, since there really aren't counterparts to a concept like this in Gecko.  There MIGHT be a way to do this entirely on the Android/Java side, but I haven't figured that out yet.

This code could definitely be made cleared and more brief by writing some helper functions to handle getting text and selections from Gecko (there's a lot of cut-and-paste "send message; try { get results } catch { ... }" boilerplate happening, but that also is better done in a follow-up.

Comment 3

[Brian Crowder]

Comment on attachment 489899 [details] [diff] [review]
Implement performContextMenuAction

I also commented out a couple of other extraneous log messages in this module.

Comment 4

[Michael Wu [:mwu]]

Comment on attachment 489899 [details] [diff] [review]
Implement performContextMenuAction

Looks good.

Comment 5

[Brian Crowder]

http://hg.mozilla.org/mozilla-central/rev/765c12dc002f