601304 - border absent between browser content and add-ons bar

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Bill Gianopoulos [:WG9s]]

There is no border between the browser content area and the add-ons bar.  This is only an issue if the content background color is similar to the add-ons bar background color.

I added the following to my userChrome.css file which seems to work, but I am not sure this is the correct element to put the border on.  I am also not sure if this should just go into browser.css or seperately in each theme.

#browser-bottombox {
  border-top: 1px solid rgb(184, 173, 157) !important;
}

Comment 1

[Valerio]

With your code after that you activate the findbar there is a 2px border-top. Try this, it works well:

#addon-bar,
#FindToolbar {
  -moz-appearance: none !important;
  border: 0 !important;
  border-top: 1px solid ThreedShadow !important;
}

statusbar {
  background: none !important;
  margin-top: 0 !important;
}

Comment 2

[Bill Gianopoulos [:WG9s]]

I think this issue will be fixed by bug 588764.

Comment 3

[Valerio]

Do you know if the addon bar will be completely glassy?

Comment 4

[Dietrich Ayala (:dietrich)]

(In reply to comment #2)
> I think this issue will be fixed by bug 588764.

That's fixed now, and looks fixed for me in the latest nightly. Is it fixed for you?

Comment 5

[gadjo]

Attachment: screenshot

Comment 6

[gadjo]

Doesn't look fixed in 20101228 build (win7, clean profile), see the "screenshot" attachment

Comment 7

[Dão Gottwald [:dao]]

Attachment: patch

This fixes it for Windows and Linux. Mac is already using -moz-appearance: statusbar; (bug 616017).

Comment 8

[Bill Gianopoulos [:WG9s]]

(In reply to comment #7)
> Created attachment 508218 [details] [diff] [review]
> patch
> 
> This fixes it for Windows and Linux. Mac is already using -moz-appearance:
> statusbar; (bug 616017).

This looks fine under Windows.  Under Linux, the border between the addons-bar and content is still not as distinctive as the border between the find-bar and content.

The find-bar top border is defined as:

  border-top: 2px solid;
  -moz-border-top-colors: ThreeDShadow ThreeDHighlight;

Comment 9

[Bill Gianopoulos [:WG9s]]

I should have mentioned, that I am not advocating for either of these to be correct.  It just seems to me that this is both the same case.  whatever chrome toolbar abuts the content at the bottom, the border should be the same.  SO whatever the correct design here is, it needs to be both the top border for the addon-bar and the find-bar.

Comment 10

[Dão Gottwald [:dao]]

We don't want to copy the find bar here, and I don't want to change the look of the find bar here either. Please file a new bug on that.

Comment 11

[Dietrich Ayala (:dietrich)]

Comment on attachment 508218 [details] [diff] [review]
patch

looks good, thanks for polishing this.

i'm not sure that the two bars need to be consistent either. the find bar is transient UI*, so the border needs to be more distinctive so the user can quickly pick it out, whereas the add-on bar is always in the same place.

(* my wife leaves the find bar open for weeks at a time. we should do a Test Pilot study on how often it's left open :P)

Comment 12

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/ba3fe7ee56b9

Comment 13

[Thomas Ahlblom]

Is this issue really fixed in Linux?

I can't find a Nightly where there's a visible border between the browser content and the Add-on bar.

Comment 14

[:aceman]

Attachment: Addon bar and addon manager open. There is no separating line between them.

Comment 15

[:aceman]

Attachment: Sample HTML that tries to mimic the addon bar CSS.

This CSS is found in omni.jar/chrome/browser/skin/classic/browser/browser.css#addon-bar . In the page, this CSS definition seems to have a border on top (shadow). But the real addon bar seems not to have it.