Last Comment Bug 601364 - search.t should also test the basic standard search parameters
: search.t should also test the basic standard search parameters
Status: RESOLVED FIXED
:
Product: Bugzilla
Classification: Server Software
Component: Testing Suite (show other bugs)
: 4.1
: All All
: -- enhancement (vote)
: Bugzilla 4.2
Assigned To: Max Kanat-Alexander
: default-qa
Mentors:
Depends on: 601370 601371
Blocks:
  Show dependency treegraph
 
Reported: 2010-10-02 08:36 PDT by Max Kanat-Alexander
Modified: 2010-10-02 09:27 PDT (History)
0 users
mkanat: approval+
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
v1 (4.22 KB, patch)
2010-10-02 08:52 PDT, Max Kanat-Alexander
mkanat: review+
Details | Diff | Review
Fix (858 bytes, patch)
2010-10-02 09:25 PDT, Max Kanat-Alexander
mkanat: review+
Details | Diff | Review

Description Max Kanat-Alexander 2010-10-02 08:36:20 PDT
Right now, we only test things via the boolean charts, but we should also make sure that the standard search parameters (and particularly the special ones, like chfield) continue to work exactly as they always have (or better).
Comment 1 Max Kanat-Alexander 2010-10-02 08:51:35 PDT
Okay, I'm going to focus and limit this first bug to just testing the simple standard search parameters, the basic field=value ones.
Comment 2 Max Kanat-Alexander 2010-10-02 08:52:42 PDT
Created attachment 480393 [details] [diff] [review]
v1
Comment 3 Max Kanat-Alexander 2010-10-02 08:54:05 PDT
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified xt/lib/Bugzilla/Test/Search.pm
modified xt/lib/Bugzilla/Test/Search/FieldTest.pm                              
added xt/lib/Bugzilla/Test/Search/FieldTestNormal.pm
modified xt/lib/Bugzilla/Test/Search/OperatorTest.pm
Committed revision 7498.
Comment 4 Max Kanat-Alexander 2010-10-02 09:00:35 PDT
Oh, wait, there's a bug in this patch that is preventing it from actually doing the right thing.
Comment 5 Max Kanat-Alexander 2010-10-02 09:25:42 PDT
Created attachment 480403 [details] [diff] [review]
Fix

This fixes the search test to actually work. (The problem before was that it was re-using the existing search_params from $field_test.)
Comment 6 Max Kanat-Alexander 2010-10-02 09:27:24 PDT
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified xt/lib/Bugzilla/Test/Search/FieldTestNormal.pm
Committed revision 7501.

Note You need to log in before you can comment on or make changes to this bug.