601409 - searchbar-engine-button only child inside a very anonymous box without attributes

Status: RESOLVED INVALID

(Firefox :: Search, defect)

Description

[Exple]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0b6) Gecko/20100101 Firefox/4.0b6
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b6) Gecko/20100101 Firefox/4.0b6

The button element with class and anonid "searchbar-engine-button" is placed inside a box element without any other children or any attributes. I am assuming this is a bug, because the only difference I see is that it unnecessarily breaks backward-compatibility with add-ons and unnecessarily complicates the DOM structure.
If this is not a bug and there is an advantage to this, then I apologize and please WONTFIX this.

Reproducible: Always



Expected Results:  
In older versions, searchbar-engine-button is simply placed inside searchbar-textbox.

Comment 1

[Exple]

The problem is in chrome://browser/content/search/search.xml, lines 37-52.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Thanks for the report, but this is indeed intentional. The box is needed to properly position the button within the containing autocomplete binding (i.e. for it to fall into http://hg.mozilla.org/mozilla-central/annotate/cf80c0d4f46e/toolkit/content/widgets/autocomplete.xml#l27 rather than http://hg.mozilla.org/mozilla-central/annotate/cf80c0d4f46e/toolkit/content/widgets/autocomplete.xml#l32).

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Though it would be good to add a comment about that in the file, did that in https://hg.mozilla.org/integration/mozilla-inbound/rev/0653ee9db9f2

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0653ee9db9f2