navigatorOverlay.xul still has a reference to BrowserSearchInternet (Tools > Search the Web doesn't work)

RESOLVED FIXED in seamonkey2.1b1

Status

SeaMonkey
Search
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Ian Neal, Assigned: Robert Kaiser)

Tracking

Trunk
seamonkey2.1b1

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
See https://bugzilla.mozilla.org/show_bug.cgi?id=410613#c58
Comment on attachment 479086 [details] [diff] [review]
v2.1: address Neil's comments

>-      BrowserSearchInternet();
>+      BrowserSearch.webSearch();
Missed a call in navigatorOverlay.xul :-(
(Reporter)

Updated

7 years ago
(Reporter)

Updated

7 years ago
(Assignee)

Updated

7 years ago
Summary: navigatorOverlay.xul still has a reference to BrowserSearchInternet → navigatorOverlay.xul still has a reference to BrowserSearchInternet (Tools > Search the Web doesn't work)
(Assignee)

Comment 1

7 years ago
Created attachment 480753 [details] [diff] [review]
Fix this instance as well

With this patch, "Tools > Search the Web" should work again.
Assignee: nobody → kairo
Status: NEW → ASSIGNED
Attachment #480753 - Flags: review?(neil)

Comment 2

7 years ago
Comment on attachment 480753 [details] [diff] [review]
Fix this instance as well

[I now hit the null checks as previously mentioned.]
Attachment #480753 - Flags: review?(neil) → review+
(Assignee)

Comment 3

7 years ago
Landed as http://hg.mozilla.org/comm-central/rev/d6f93d5b6f45
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b1
You need to log in before you can comment on or make changes to this bug.