Last Comment Bug 601466 - navigatorOverlay.xul still has a reference to BrowserSearchInternet (Tools > Search the Web doesn't work)
: navigatorOverlay.xul still has a reference to BrowserSearchInternet (Tools > ...
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Search (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.1b1
Assigned To: Robert Kaiser
:
Mentors:
http://mxr.mozilla.org/comm-central/s...
Depends on: 410613
Blocks:
  Show dependency treegraph
 
Reported: 2010-10-03 06:09 PDT by Ian Neal
Modified: 2010-10-05 16:11 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Fix this instance as well (1.12 KB, patch)
2010-10-04 15:07 PDT, Robert Kaiser
neil: review+
Details | Diff | Splinter Review

Description Ian Neal 2010-10-03 06:09:52 PDT
See https://bugzilla.mozilla.org/show_bug.cgi?id=410613#c58
Comment on attachment 479086 [details] [diff] [review]
v2.1: address Neil's comments

>-      BrowserSearchInternet();
>+      BrowserSearch.webSearch();
Missed a call in navigatorOverlay.xul :-(
Comment 1 Robert Kaiser 2010-10-04 15:07:23 PDT
Created attachment 480753 [details] [diff] [review]
Fix this instance as well

With this patch, "Tools > Search the Web" should work again.
Comment 2 neil@parkwaycc.co.uk 2010-10-05 01:39:40 PDT
Comment on attachment 480753 [details] [diff] [review]
Fix this instance as well

[I now hit the null checks as previously mentioned.]
Comment 3 Robert Kaiser 2010-10-05 16:11:31 PDT
Landed as http://hg.mozilla.org/comm-central/rev/d6f93d5b6f45

Note You need to log in before you can comment on or make changes to this bug.