The default bug view has changed. See this FAQ.

parallel xforms and schema-validation build sometimes fails due to race

RESOLVED FIXED in mozilla2.0b8

Status

Core Graveyard
XForms
RESOLVED FIXED
7 years ago
8 months ago

People

(Reporter: imphil, Assigned: imphil)

Tracking

Trunk
mozilla2.0b8
x86_64
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Since bug 463385 modified extensions/Makefile.in to use PARALLEL_DIRS instead of DIRS for all extensions we have a race condition when doing parallel builds of schema-validation and xforms.

xforms (in http://hg.mozilla.org/xforms/file/3bd9353a5347/Makefile.in#l101) adds schema-validation to its DIRS, causing it to be built twice in parallel (once from extensions/Makefile and once from extensions/xforms/Makefile). This may work from time to time, but generally gives errors like this one:

/home/philipp/src/mozilla-central/obj-debug/config/nsinstall -R -m 644 /home/philipp/src/mozilla-central/extensions/schema-validation/public/nsISVSchemaErrorHandler.idl /home/philipp/src/mozilla-central/extensions/schema-validation/public/nsISVSchema.idl /home/philipp/src/mozilla-central/extensions/schema-validation/public/nsISVSchemaLoader.idl /home/philipp/src/mozilla-central/extensions/schema-validation/public/nsISchemaValidator.idl /home/philipp/src/mozilla-central/extensions/schema-validation/public/nsISchemaDuration.idl /home/philipp/src/mozilla-central/extensions/schema-validation/public/nsISchemaValidatorRegexp.idl ../../../dist/idl
/home/philipp/src/mozilla-central/obj-debug/config/nsinstall: cannot make symbolic link /home/philipp/src/mozilla-central/obj-debug/dist/idl/nsISVSchemaLoader.idl: File exists
make[6]: *** [export] Fehler 1
make[6]: Leaving directory `/home/philipp/src/mozilla-central/obj-debug/extensions/schema-validation/public'


Neil, since you made this change initially, do you have an idea how to solve this? Or could you CC someone else that might know how? ;)
(Assignee)

Comment 1

7 years ago
ah wrong bug, I meant bug 462381 and that means Mitchell instead of Neil. The question above stays the same. Sorry for the confusion.

Comment 2

7 years ago
Ah, so xforms depends on schema-validation, and unconditionally builds it? Can you not remove schema-validation from your --enable-extensions list?
(Assignee)

Comment 3

7 years ago
Thanks Neil, that seems to work indeed (simple and easy!) It only needs a small patch to the configure.in to remove the enforcement of that schema-validation dependency. I've attached a patch, but I'll do some more tests on different platforms before asking for review on this one.
(Assignee)

Comment 4

7 years ago
Created attachment 480666 [details] [diff] [review]
patch to configure.in
(Assignee)

Updated

7 years ago
Attachment #480666 - Flags: review?(ted.mielczarek)
Attachment #480666 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Updated

7 years ago
Assignee: nobody → mail
Keywords: checkin-needed
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
(Assignee)

Comment 5

7 years ago
Comment on attachment 480666 [details] [diff] [review]
patch to configure.in

Requesting approval2.0 because we need this for XForms to build reliably with Gecko 2.0.
Attachment #480666 - Flags: approval2.0?

Updated

7 years ago
Attachment #480666 - Flags: approval2.0? → approval2.0+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
(Assignee)

Comment 6

7 years ago
Created attachment 483317 [details] [diff] [review]
[for checkin] configure.in changes
Attachment #480666 - Attachment is obsolete: true

Comment 7

7 years ago
Philipp, did you start try server build? That's good guarantee the patch is safe to checkin?
(Assignee)

Comment 8

7 years ago
yes, it builds on all platforms.

Comment 9

7 years ago
landed http://hg.mozilla.org/mozilla-central/rev/71db9b08ee9a
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
(Assignee)

Comment 10

7 years ago
build documentation updated: https://developer.mozilla.org/en/XForms/Building_Mozilla_XForms

newsgroup announcement:
http://groups.google.com/group/mozilla.dev.tech.xforms/browse_frm/thread/235167133a455e61
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.