601634 - talos fails to complete test on android for tsvg, tdhtml, tp4

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

I am unable to complete a test run on android of tsvg, tp4, or tdhtml.  I can run the same tools on a maemo device and get successful results.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: adjust talos timeout and process monitoring (1.0)

the android agent uses async launch and talos was counting on sync launching of fennec.  This ended up causing a timeout and any test taking longer than a couple minutes would fail on android.

This patch updates the devicemanager to always poll for the process and add a testTimeout flag to talos to specify the timeout since tests will take longer on mobile devices than desktop.

Comment 2

[alice nodelman [:alice] [:anode]]

The test timeout that you've put in sample.config is shorter than the original default - we should stick with what we had there.

Comment 3

[cmtalbert]

Comment on attachment 481202 [details] [diff] [review]
adjust talos timeout and process monitoring (1.0)

The devicemanager changes look good.  

I didn't really pay much attention to the talos changes since Alice is the expert there.

Comment 4

[alice nodelman [:alice] [:anode]]

Comment on attachment 481202 [details] [diff] [review]
adjust talos timeout and process monitoring (1.0)

I'm still seeing

+test_timeout: 900

We want to stick with the current test timeout for everything but mobile, so this patch shouldn't be changing the default behavior.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: adjust talos timeout and process monitoring (2.0)

updated patch (which is green on talos staging) to force data types and default values.  Also use 1200 as the default, not 900...bad 1st patch, bad!

Comment 6

[alice nodelman [:alice] [:anode]]

Comment on attachment 482632 [details] [diff] [review]
adjust talos timeout and process monitoring (2.0)

Looks good to me.

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

are the next steps to check this into hg and then create a releng bug for treeclosure (similar to bug 602055)?

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

http://hg.mozilla.org/build/talos/rev/63d6234bcf86