Closed Bug 601732 Opened 13 years ago Closed 13 years ago

Change "seperator" to "separator" in code

Categories

(Camino Graveyard :: General, defect)

Product:
Camino Graveyard
Component:
General
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bugzilla-graveyard, Assigned: phiw2)

Details

Attachments

(1 file)

fix
4.25 KB, patch
stuart.morgan+bugzilla
: superreview+
Details | Diff | Splinter Review 
There are five instances of "seperator" in our codebase. Four are simply mistakes, and the fifth is the remnants of the lovely "Norwagian" (read: Opera's) spelling of it in our bookmarks import code. The four should be fixed, and the fifth needs a comment (maybe we can bring back the hilarious comments from the now-deleted old bookmarks importer?) so no one tries to "fix" it in the future.

Typos:
  AppListMenuFactory.mm, lines 120/140/168
  BrowserWindowController.mm, line 5259

Needs a comment:
  OperaBookmarkConverter.m, line 51
Attached patch fix — — Splinter Review 
simple search and replace.


(the 4 line comment in comment 1 was funny, but made the code much harder to read)
Assignee: nobody → phiw
Status: NEW → ASSIGNED
Attachment #480855 - Flags: review?(cl-bugs-new2)
Comment on attachment 480855 [details] [diff] [review]
fix

(per IRC comments that can straight to SR)
Attachment #480855 - Flags: review?(cl-bugs-new2) → superreview?(stuart.morgan+bugzilla)
Comment on attachment 480855 [details] [diff] [review]
fix

sr=smorgan
Attachment #480855 - Flags: superreview?(stuart.morgan+bugzilla) → superreview+
http://hg.mozilla.org/camino/rev/198e8427d949
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.