Closed Bug 601770 Opened 13 years ago Closed 13 years ago

mDelegateTooltipStringForItem is a terrible name for a BOOL

Categories

(Camino Graveyard :: General, defect)

Product:
Camino Graveyard
Component:
General
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bugzilla-graveyard, Assigned: phiw2)

Details

Attachments

(1 file)

fix
2.64 KB, patch
stuart.morgan+bugzilla
: superreview+
Details | Diff | Splinter Review 
In ExtendedOutlineView, we have a BOOL named "mDelegateTooltipStringForItem", which makes it sound like a string. We should re-name this variable to something better.

I'd suggest "mDelegateItemHasTooltipString", based on how it's used.

Stuart, any suggestions?
That's not what it means though; look at the definition. mDelegateImplementsTooltipStringForItem would work.
(In reply to comment #1)
> That's not what it means though; look at the definition.
> mDelegateImplementsTooltipStringForItem would work.

That's fine by me. Thanks for catching that.
Attached patch fix — — Splinter Review 
Implements comment 1.
Assignee: nobody → phiw
Status: NEW → ASSIGNED
Attachment #481764 - Flags: superreview?(stuart.morgan+bugzilla)
Comment on attachment 481764 [details] [diff] [review]
fix

sr=smorgan
Attachment #481764 - Flags: superreview?(stuart.morgan+bugzilla) → superreview+
http://hg.mozilla.org/camino/rev/aefe7d128143
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.