Closed
Bug 601770
Opened 15 years ago
Closed 15 years ago
mDelegateTooltipStringForItem is a terrible name for a BOOL
Categories
(Camino Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bugzilla-graveyard, Assigned: phiw2)
Details
Attachments
(1 file)
|
2.64 KB,
patch
|
stuart.morgan+bugzilla
:
superreview+
|
Details | Diff | Splinter Review |
In ExtendedOutlineView, we have a BOOL named "mDelegateTooltipStringForItem", which makes it sound like a string. We should re-name this variable to something better.
I'd suggest "mDelegateItemHasTooltipString", based on how it's used.
Stuart, any suggestions?
|
||
Comment 1•15 years ago
|
||
That's not what it means though; look at the definition. mDelegateImplementsTooltipStringForItem would work.
|
Reporter | |
Comment 2•15 years ago
|
||
(In reply to comment #1)
> That's not what it means though; look at the definition.
> mDelegateImplementsTooltipStringForItem would work.
That's fine by me. Thanks for catching that.
|
|
Assignee | |
Comment 3•15 years ago
|
||
Implements comment 1.
Assignee: nobody → phiw
Status: NEW → ASSIGNED
Attachment #481764 -
Flags: superreview?(stuart.morgan+bugzilla)
|
|
||
Comment 4•15 years ago
|
||
Comment on attachment 481764 [details] [diff] [review]
fix
sr=smorgan
Attachment #481764 -
Flags: superreview?(stuart.morgan+bugzilla) → superreview+
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•