601774 - IndexedDB: Audit exceptions thrown from indexedDB methods

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Need to make sure we don't leak implementation details through exceptions, and need to make sure we throw the exception code that the spec suggests.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

This fixes all our error codes, I think.

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 485516 [details] [diff] [review]
Patch, v1

> IDBDatabase::RemoveObjectStore(const nsAString& aName)
...
>   if (aName.IsEmpty()) {
>-    return NS_ERROR_INVALID_ARG;
>-  }

Just remove this part.

I have to say though, I think this patch is a really bad idea. It'll make debugging harder both for us and for authors to clamp all the errors.

The security review comments was only about the security sensitive errors. Feel free to check this with the others who were at the review :)

The only security sensitive errors that I can think of are file handling related ones, and possibly ones related to what particular version of sqlite is installed.

So only return values from sqlite are the ones we should clamp.

I'm fine with doing this for now though.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

http://hg.mozilla.org/mozilla-central/rev/fcaf91df3004