601848 - percentage_complete searches are broken in various ways

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Max Kanat-Alexander]

One of the most broken search fields in Search.pm is percentage_complete, mostly because it's using a HAVING clause, so it can't be negated or involved in the AND/OR structure of boolean charts like other fields can.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

This fully fixes the percentage_complete field! Basically there are two fixes involved:

1) Make actual_time come from a derived table instead of being part of an expression. This allows us to use percentage_complete and actual_time in the WHERE clause instead of in the HAVING clause, fixing most of our problems.

2) Make the percentage_complete column an integer when it's returned by the database, instead of a floating-point number. This makes the behavior of percentage_complete searches predictable and correct across all operators and both tested databases. I choose FLOOR instead of ROUND because that way 99.5% doesn't show up as 100% in buglists.

Comment 2

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Bug.pm
modified Bugzilla/Search.pm
modified xt/lib/Bugzilla/Test/Search/Constants.pm
modified xt/lib/Bugzilla/Test/Search/FieldTest.pm
Committed revision 7520.