601928 - [D3D9] Crash after creation of temporary texture fails [@ mozilla::layers::ThebesLayerD3D9::DrawRegion(nsIntRegion const&)]

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Bas Schouten (:bas.schouten)]

For some reason it appears there's situations where our creation of a temporary texture in system memory fails, and we proceed to reference a NULL pointer. We should bail when the creation of our temporary texture fails.

Comment 1

[Scoobidiver (away)]

Crash reports of the last 2 weeks are at :
http://crash-stats.mozilla.com/report/list?product=Firefox&query_search=signature&query_type=exact&query=mozilla%3A%3Alayers%3A%3AThebesLayerD3D9%3A%3ADrawRegion%28nsIntRegion%20const%26%29&range_value=2&range_unit=weeks&hang_type=any&process_type=any&plugin_field=&plugin_query_type=&plugin_query=&do_query=1&admin=&signature=mozilla%3A%3Alayers%3A%3AThebesLayerD3D9%3A%3ADrawRegion%28nsIntRegion%20const%26%29

Comment 2

[Bas Schouten (:bas.schouten)]

Attachment: Check result of create texture for tmpTexture

We should bail if this CreateTexture call fails. Although it's a bad sign that this occurs and might cause rendering issues, this is better than crashing. It would be good if we could figure out why this happens though. But for now let's kill the crash.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 480924 [details] [diff] [review]
Check result of create texture for tmpTexture

Any reason we shouldn't just OOM here?

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 480924 [details] [diff] [review]
Check result of create texture for tmpTexture

Or rather, this feels like we're just papering over a problem. I think we need to learn more before we ignore this.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

(In reply to comment #4)
> Comment on attachment 480924 [details] [diff] [review]
> Check result of create texture for tmpTexture
> 
> Or rather, this feels like we're just papering over a problem. I think we need
> to learn more before we ignore this.

Also, does this only happen on particular hardware?

Comment 6

[Bas Schouten (:bas.schouten)]

Attachment: Check result of create texture for tmpTexture v2

As discussed on IRC. This also creates a useful helper function that will in the future allow us to expose error result codes in a variety of ways that seem useful. A follow up bug will be created to move other function calls to using this for error reporting.

Comment 7

[Joe Drew (not getting mail)]

Let's try to get this into nightlies right after b7 ships.

Comment 8

[Bas Schouten (:bas.schouten)]

http://hg.mozilla.org/mozilla-central/rev/d4a525c50805