601934 - The hedgehog doesn't walk anymore

Status: RESOLVED DUPLICATE of bug 571863

(Core :: SVG, defect)

Description

[Boris Zbarsky [:bzbarsky]]

BUILD: Any trunk build starting 2010-02-12.

STEPS TO REPRODUCE:  Load http://www.carlosvives.es/hedgewars/svg/

EXPECTED RESULTS: Hedgehog walks

ACTUAL RESULTS: Hedgehog just flexes feet/hands

Regression range: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=af0f0615944e&tochange=4b18d31e83f4

Likely regression from bug 545550.

Might be fixed by fixing bug 593182.

Comment 1

[Robert Longson [:longsonr]]

Does applying the patch in bug 571863 fix it?

Comment 2

[Daniel Holbert [:dholbert]]

(In reply to comment #1)
> Does applying the patch in bug 571863 fix it?

Sadly, no.

Comment 3

[Daniel Holbert [:dholbert]]

This becomes fixed if I add back this line
  aSVGElement->DidChangeLength(mAttrEnum, aDoSetAttr);
to nsSVGLength2::SetBaseValueString().

(That means the comment there at the end is incorrect:
403 nsSVGLength2::SetBaseValueString(const nsAString &aValueAsString,
[...]
426   // We don't need to call DidChange* here - we're only called by
427   // nsSVGElement::ParseAttribute under nsGenericElement::SetAttr,
428   // which takes care of notifying.
429   return NS_OK;

http://mxr.mozilla.org/mozilla-central/source/content/svg/content/src/nsSVGLength2.cpp#426

Comment 4

[Robert Longson [:longsonr]]

If you break on that is it called from somewhere other than ParseAttribute in this case?

Comment 5

[Daniel Holbert [:dholbert]]

This is inside of ParseAttribute. It appears that the nsGenericElement notifications don't take care of everything that DidChangeLength takes care of -- in particular, the call to InvalidateTransformNotifyFrame, per Bug 593182 comment 15.

Let's take this discussion to Bug 593182 for now, because I'm pretty sure "Second testcase" there is effectively a reduced version of this bug's testcase, whereas this bug's URL has too many simultaneous changes to be easily debugged. :)

Comment 6

[Daniel Holbert [:dholbert]]

This should hopefully be fixed in tomorrow's nightly, since I just landed Robert's patch from bug 571863.

Comment 7

[José Jeria]

Build ID: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101008 Firefox/4.0b8pre

Hedgehog walks again

Comment 8

[Daniel Holbert [:dholbert]]

Hooray! Duping to (fixed) bug 571863, then.