601984 - 2-byte/4-byte wchar mismatch warnings

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

mwu, any reason we shouldn't do this? code size is the only thing I can think of

Comment 1

[Benjamin Smedberg]

Comment on attachment 480968 [details] [diff] [review]
patch

Really really we shouldn't do this: 2-byte wchar is essential to making NS_LITERAL_STRING perform correctly, unless we're building using GCC 4.4+ which has u"" string-literal support.

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

we are using gcc 4.4

Comment 3

[Michael Wu [:mwu]]

We shouldn't expect proper support support for short wchar_t on android. Their plan is to make wc* functions all use 32bit wchar_t. As long as we don't use the system string functions, we should be ok.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch to ignore warnings

per discussion on irc, we should just ignore these warnings

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 481034 [details] [diff] [review]
patch to ignore warnings

WCHAR_CFLAGS is used only for the xulrunner pkgconfig info.  You probably want to also add -Wl,--no-wchar-size-warning to CFLAGS too.

Comment 6

[Doug Turner (:dougt)]

Comment on attachment 481034 [details] [diff] [review]
patch to ignore warnings

build change, android only actual change.  Make sure that this builds successfully.

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/d30d0303cd0f

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

sorry, wrong changeset, pushed http://hg.mozilla.org/mozilla-central/rev/156e39355da2