mwu, any reason we shouldn't do this? code size is the only thing I can think of
Comment on attachment 480968 [details] [diff] [review] patch Really really we shouldn't do this: 2-byte wchar is essential to making NS_LITERAL_STRING perform correctly, unless we're building using GCC 4.4+ which has u"" string-literal support.
Attachment #480968 - Flags: review?(khuey) → review-
we are using gcc 4.4
We shouldn't expect proper support support for short wchar_t on android. Their plan is to make wc* functions all use 32bit wchar_t. As long as we don't use the system string functions, we should be ok.
per discussion on irc, we should just ignore these warnings
Comment on attachment 481034 [details] [diff] [review] patch to ignore warnings WCHAR_CFLAGS is used only for the xulrunner pkgconfig info. You probably want to also add -Wl,--no-wchar-size-warning to CFLAGS too.
Attachment #481034 - Flags: review?(khuey) → review+
Attachment #481034 - Flags: approval2.0?
Comment on attachment 481034 [details] [diff] [review] patch to ignore warnings build change, android only actual change. Make sure that this builds successfully.
Attachment #481034 - Flags: approval2.0? → approval2.0+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
sorry, wrong changeset, pushed http://hg.mozilla.org/mozilla-central/rev/156e39355da2
You need to log in before you can comment on or make changes to this bug.