Closed
Bug 601984
Opened 14 years ago
Closed 14 years ago
2-byte/4-byte wchar mismatch warnings
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: blassey, Assigned: blassey)
Details
Attachments
(1 file, 1 obsolete file)
1.23 KB,
patch
|
khuey
:
review+
dougt
:
approval2.0+
|
Details | Diff | Splinter Review |
mwu, any reason we shouldn't do this? code size is the only thing I can think of
Attachment #480968 -
Flags: review?(mwu)
Attachment #480968 -
Flags: review?(khuey)
Comment 1•14 years ago
|
||
Comment on attachment 480968 [details] [diff] [review] patch Really really we shouldn't do this: 2-byte wchar is essential to making NS_LITERAL_STRING perform correctly, unless we're building using GCC 4.4+ which has u"" string-literal support.
Attachment #480968 -
Flags: review?(khuey) → review-
Assignee | ||
Comment 2•14 years ago
|
||
we are using gcc 4.4
Comment 3•14 years ago
|
||
We shouldn't expect proper support support for short wchar_t on android. Their plan is to make wc* functions all use 32bit wchar_t. As long as we don't use the system string functions, we should be ok.
Updated•14 years ago
|
Attachment #480968 -
Flags: review?(mwu)
Assignee | ||
Comment 4•14 years ago
|
||
per discussion on irc, we should just ignore these warnings
Attachment #480968 -
Attachment is obsolete: true
Attachment #481034 -
Flags: review?(khuey)
Comment on attachment 481034 [details] [diff] [review] patch to ignore warnings WCHAR_CFLAGS is used only for the xulrunner pkgconfig info. You probably want to also add -Wl,--no-wchar-size-warning to CFLAGS too.
Attachment #481034 -
Flags: review?(khuey) → review+
Assignee | ||
Updated•14 years ago
|
Attachment #481034 -
Flags: approval2.0?
Comment 6•14 years ago
|
||
Comment on attachment 481034 [details] [diff] [review] patch to ignore warnings build change, android only actual change. Make sure that this builds successfully.
Attachment #481034 -
Flags: approval2.0? → approval2.0+
Assignee | ||
Comment 7•14 years ago
|
||
pushed http://hg.mozilla.org/mozilla-central/rev/d30d0303cd0f
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•14 years ago
|
||
sorry, wrong changeset, pushed http://hg.mozilla.org/mozilla-central/rev/156e39355da2
Updated•13 years ago
|
Assignee: nobody → blassey.bugs
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•