Closed Bug 602024 Opened 10 years ago Closed 9 years ago

mixed licensing in HUDService.jsm is confusing

Categories

(DevTools :: General, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Gavin, Assigned: msucan)

References

Details

(Whiteboard: [patchclean:1201])

Attachments

(1 file, 1 obsolete file)

HUDService includes a block of code copied from Firebug, used under different license terms as the rest of the file.

Rather than surrounding it with comments, we should just put it into it's own file (either via a preprocessor #include, or even better as a self-contained JS module), like we did with stylePanel.jsm for inspector.
(In reply to comment #0)
> or even better as a self-contained JS
> module), like we did with stylePanel.jsm for inspector.

Agreed. Separate file is best, as we do not want to hunt for the correct line number on errors.
Blocks: devtools4b8
Assignee: nobody → mihai.sucan
After we do this we'd need to update the comment in http://hg.mozilla.org/mozilla-central/rev/17f25ba7a1f3 as well, I believe.
Attached patch proposed patch (obsolete) — Splinter Review
Proposed patch.

This patch moves the firebug code into a new NetworkHelper.jsm. No regressions, during testing. I also updated the toolkit/content/license.html as was suggested in the comment above.
Attachment #484395 - Flags: feedback?(rcampbell)
Status: NEW → ASSIGNED
Whiteboard: [patchclean:1019]
mass change: filter on PRIORITYSETTING
Blocks: devtools4
Priority: -- → P3
Attachment #484395 - Flags: review+
Attachment #484395 - Flags: approval2.0+
Attachment #484395 - Flags: feedback?(rcampbell) → feedback+
Rebased the patch.

Thanks for the f+, r+ and a+!
Attachment #484395 - Attachment is obsolete: true
Whiteboard: [patchclean:1019] → [patchclean:1201][checkin]
Comment on attachment 494467 [details] [diff] [review]
[checked-in] rebased patch

http://hg.mozilla.org/mozilla-central/rev/b92216d0aea9
Attachment #494467 - Attachment description: rebased patch → [checked-in] rebased patch
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [patchclean:1201][checkin] → [patchclean:1201]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.