602040 - Fix waitForPageLoad for error pages by using the document's readyState

Status: VERIFIED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

We still have problems in correctly detecting the final state of a page load for error pages. The reason is that DOMContentLoaded gets fired once we reach the readyState==complete. Error pages will never reach that state and that's why the named event will never be fired. The state error pages reach is "interactive". The DOM will not be ready by that time, and given that there is no other event fired, we have to wait about 1s.

The patch which I will attach in a minute will fix all those problems and correctly detects when a page has been finished loading.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Attachment: Patch v1

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Attachment: Patch v1.1

Missed the important divider for parameters for the baseURI.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Landed on hotfix-1.5.1:
http://github.com/mozautomation/mozmill/commit/efa4ca89019be7d57774067ea77fbea13a405f13

Comment 4

[Aaron Train [:aaronmt]]

Verified  fixed with 1.5.1rc1

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Landed on master as:
http://github.com/mozautomation/mozmill/commit/37d4caf7dcce470798257a62a27323286c8e4040