602091 - Error icons/symbols should probably be to the left of the error text, not the right

Status: RESOLVED FIXED

(support.mozilla.org :: Army of Awesome, task, P4)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

Definitely not a launch blocker, but the error icons/symbols should probably be to the left of the text, not the right.

STR:

1. Load https://support-stage.mozilla.com/en-US/army-of-awesome
2. Enter more than 140 characters, or clear the text out, and hit "Send"

Comment 1

[Alex Buchanan [:abuchanan]]

Why?

If so, should the success message checkmark be on the left side too?  It should be consistent, I'd think.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #1)
> Why?
> 
> If so, should the success message checkmark be on the left side too?  It should
> be consistent, I'd think.

Yes.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

See bug 592117 for precedence, and I talked to chowse about this yesterday, too, and he's in agreement.

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

The icon is still there on the right side. Adding mentor bits.

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

Anush wants to work on this.

Comment 6

[Anush [:anushbmx]]

PR https://github.com/mozilla/kitsune/pull/1947

Comment 7

[Michael Cooper [:mythmon]]

Landed in bd422a2 [bug 602091] Fixes issue with error icon symbol in Army of Awesome

Comment 8

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod now.