Closed
Bug 602151
Opened 14 years ago
Closed 14 years ago
Too many calls to OnValueChanged
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla2.0b7
People
(Reporter: bzbarsky, Assigned: ehsan.akhgari)
References
(Blocks 1 open bug)
Details
(Keywords: perf)
Attachments
(1 file)
3.60 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
approval2.0+
|
Details | Diff | Splinter Review |
See bug 190147 comment 30, this part: We call nsHTMLTextAreaElement::OnValueChanged from both nsTextInputListener::EditAction _and_ from nsTextEditorState::SetValue directly. The upshot is that we do 2x the notification we really need to do. Can we avoid this?
Is this also affecting bug 597627?
Reporter | ||
Comment 2•14 years ago
|
||
I doubt it; I don't recall it showing up in my profile.
Assignee | ||
Comment 3•14 years ago
|
||
Those calls are coming from <http://hg.mozilla.org/mozilla-central/diff/751da00c7b53/content/html/content/src/nsTextEditorState.cpp> landed in bug 558788. But unless I'm missing something, only one of these should be called per editing operation, right?
Keywords: perf
Reporter | ||
Comment 4•14 years ago
|
||
This bug is about multiple calls to the function when .value is set on the input or textarea. One call from EditAction, and one call from the value setter itself.
Assignee | ||
Comment 5•14 years ago
|
||
(In reply to comment #4) > This bug is about multiple calls to the function when .value is set on the > input or textarea. One call from EditAction, and one call from the value > setter itself. Ah, right... I'll have a patch shortly.
Assignee | ||
Comment 6•14 years ago
|
||
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #481314 -
Flags: review?(bzbarsky)
Attachment #481314 -
Flags: approval2.0?
Reporter | ||
Comment 7•14 years ago
|
||
Comment on attachment 481314 [details] [diff] [review] Patch (v1) Ah, excellent.
Attachment #481314 -
Flags: review?(bzbarsky)
Attachment #481314 -
Flags: review+
Attachment #481314 -
Flags: approval2.0?
Attachment #481314 -
Flags: approval2.0+
Assignee | ||
Updated•14 years ago
|
Whiteboard: [needs landing]
Updated•14 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Assignee | ||
Comment 8•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/7abc5a320109
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
Target Milestone: --- → mozilla2.0b8
Updated•14 years ago
|
Target Milestone: mozilla2.0b8 → mozilla2.0b7
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•