let addon bar control widget styling related to positioning

RESOLVED FIXED

Status

Add-on SDK
General
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: dietrich, Assigned: dietrich)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

7 years ago
Created attachment 481238 [details] [diff] [review]
fix

currently each widget sets it's margins, whatnot. this patch removes that, so that the browser can control positioning, relative spacing between items on the bar, etc.

it also contains a correctness fix - we were putting a space in the id for the widget's container element.
Assignee: nobody → dietrich
Attachment #481238 - Flags: review?(myk)
Attachment #481238 - Flags: review?(myk) → review+
(Assignee)

Updated

7 years ago
Depends on: 598921
(Assignee)

Comment 2

7 years ago
pull request: https://github.com/mozilla/addon-sdk/pull/25
The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".
Component: Jetpack SDK → General
Product: Mozilla Labs → Add-on SDK
QA Contact: jetpack-sdk → general
Version: Trunk → unspecified
(Assignee)

Comment 4

7 years ago
https://github.com/mozilla/addon-sdk/commit/65b174096d84d8f5abecf96e5fbbfe03951f8a90
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.