602389 - nanojit: make Register a non-numeric type on MIPS

Status: RESOLVED FIXED

(Core Graveyard :: Nanojit, defect)

Description

[Nicholas Nethercote [inactive]]

Bug 599251 introduced the non-numeric Register type.  This back-end doesn't use it yet.  It should.  See the i386/X64 back-ends for examples.

Comment 1

[Chris Dearman]

Attachment: Support non-integer Register type

Tested in nanojit and tamarin-redux

Comment 2

[Nicholas Nethercote [inactive]]

Comment on attachment 527910 [details] [diff] [review]
Support non-integer Register type

Review of attachment 527910 [details] [diff] [review]:

r=me

Comment 3

[Chris Dearman]

Can this change be pushed now?

Comment 4

[Nicholas Nethercote [inactive]]

Sure.  Do you need someone to do it for you?  (Adding [checkin-needed] to the whiteboard is the standard way to indicate that.)

Comment 5

[Chris Dearman]

(In reply to comment #4)
> Sure.  Do you need someone to do it for you?  (Adding [checkin-needed] to
> the whiteboard is the standard way to indicate that.)

Thanks. I didn't know that so thanks for the pointer :)

Comment 6

[Dão Gottwald [:dao]]

Is this supposed to land on mozilla-central? If so, the paths in the patch are bogus.

Comment 7

[Nicholas Nethercote [inactive]]

No, it has to land on nanojit-central.  I'll do it.

Comment 8

[Nicholas Nethercote [inactive]]

http://hg.mozilla.org/projects/nanojit-central/rev/8363264654d5

Comment 9

[Tamarin Bot]

changeset: 6522:d64e8c9b0731
user:      Chris Dearman <[e-mail]>
summary:   Comment Bug 602389 - nanojit: make Register a non-numeric type on MIPS.  r=nnethercote.

http://hg.mozilla.org/tamarin-redux/rev/d64e8c9b0731

Comment 10

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/806abed2a8f7

Comment 11

[Nicholas Nethercote [inactive]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/806abed2a8f7