nanojit: make Register a non-numeric type on MIPS

RESOLVED FIXED in flash10.2

Status

Core Graveyard
Nanojit
RESOLVED FIXED
7 years ago
3 years ago

People

(Reporter: njn, Assigned: Chris Dearman)

Tracking

unspecified
flash10.2
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-nanojit][fixed-in-tamarin][inbound])

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
Bug 599251 introduced the non-numeric Register type.  This back-end doesn't use it yet.  It should.  See the i386/X64 back-ends for examples.

Updated

6 years ago
Target Milestone: --- → flash10.2
(Assignee)

Comment 1

6 years ago
Created attachment 527910 [details] [diff] [review]
Support non-integer Register type

Tested in nanojit and tamarin-redux
Attachment #527910 - Flags: review?(nnethercote)
(Reporter)

Comment 2

6 years ago
Comment on attachment 527910 [details] [diff] [review]
Support non-integer Register type

Review of attachment 527910 [details] [diff] [review]:

r=me
Attachment #527910 - Flags: review?(nnethercote) → review+
(Assignee)

Comment 3

6 years ago
Can this change be pushed now?
(Reporter)

Comment 4

6 years ago
Sure.  Do you need someone to do it for you?  (Adding [checkin-needed] to the whiteboard is the standard way to indicate that.)
(Assignee)

Comment 5

6 years ago
(In reply to comment #4)
> Sure.  Do you need someone to do it for you?  (Adding [checkin-needed] to
> the whiteboard is the standard way to indicate that.)

Thanks. I didn't know that so thanks for the pointer :)
Whiteboard: [checkin-needed]

Updated

6 years ago
Keywords: checkin-needed
Whiteboard: [checkin-needed]
Is this supposed to land on mozilla-central? If so, the paths in the patch are bogus.
(Reporter)

Comment 7

6 years ago
No, it has to land on nanojit-central.  I'll do it.
(Reporter)

Comment 8

6 years ago
http://hg.mozilla.org/projects/nanojit-central/rev/8363264654d5
Whiteboard: [fixed-in-nanojit]

Updated

6 years ago
Keywords: checkin-needed

Comment 9

6 years ago
changeset: 6522:d64e8c9b0731
user:      Chris Dearman <chris@mips.com>
summary:   Comment Bug 602389 - nanojit: make Register a non-numeric type on MIPS.  r=nnethercote.

http://hg.mozilla.org/tamarin-redux/rev/d64e8c9b0731
http://hg.mozilla.org/mozilla-central/rev/806abed2a8f7
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Reporter)

Comment 11

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/806abed2a8f7
Whiteboard: [fixed-in-nanojit] → [fixed-in-nanojit][fixed-in-tamarin][inbound]
Component: Nanojit → Nanojit
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.