602427 - Pagination/loading of/searching for similar messages seems broken for Sites

Status: VERIFIED FIXED

(Input :: General, defect, P2)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

STR:

1. Load http://input.stage.mozilla.com/en-US/sites
2. Click on YOUTUBE.COM (http://input.stage.mozilla.com/en-US/site/http/youtube.com)
3. Now click on "[num] similar messages" (http://input.stage.mozilla.com/en-US/sites/theme/987)
4. Now click on "Next Page »"

Actual Results:

Same theme remains, with no individual messages beneath it

Expected Results:

Should do a search, a la http://people.mozilla.com/~chowse/drop/mozilla.com/input/style/search.html

Comment 1

[Michael Kurze [:michaelk]]

As far as I can see, this is our old friend "need production data on stage" saying hello. Or am I missing something?

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #1)
> As far as I can see, this is our old friend "need production data on stage"
> saying hello. Or am I missing something?

Nope; you would know better than I -- is there a way I can tell what is missing data vs. broken code?  (I want to know so I don't file bugs like this.)

Comment 3

[Michael Kurze [:michaelk]]

Basically whenever...
...there is an empty Theme (except the headline opinion) *and*
...we had no data update for the last week / the latest beta (whichever selected, can be told by looking at the dashboard front page -- is it empty for 7d?), then it is most likely due to missing data. 

Of course there might be always be a real error, so we definitely need up-to-date data here.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #3)
> Basically whenever...
> ...there is an empty Theme (except the headline opinion) *and*

This is also the case, then, for the top-level "Themes" link, right (assuming so): http://input.stage.mozilla.com/en-US/themes/

Comment 5

[Michael Kurze [:michaelk]]

(In reply to comment #4)

>> Basically whenever...
>> ...there is an empty Theme (except the headline opinion) *and*

>This is also the case, then, for the top-level "Themes" link, right (assuming
>so): http://input.stage.mozilla.com/en-US/themes/

For top-level themes: Without current messages on stage, no current (top-level) themes will be generated as they try to read their data from the stage db. 

Sites *appears* to have data on first sight because it is always generated from prod data by a metrics etl machine, then pushed to both stage and prod. Once you actually try to look at a (sites) theme though, it will appear to be empty because all the messages it references are missing on stage.

So, for two different technical reasons it boils down to: stale data => *no* top-level themes, *empty* site-level themes

Comment 6

[Aakash Desai [:aakashd]]

Wait on Davedash's comments in bug 602997 later on today

Comment 7

[Michael Kurze [:michaelk]]

I do not really see a relation to bug 602997

Stephen/Aakash: is this still an issue with an up-to-date production database dump?

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #7)
> I do not really see a relation to bug 602997
> 
> Stephen/Aakash: is this still an issue with an up-to-date production database
> dump?

Yes, comment 0 is still the case.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

We got another DB dump tonight, so either that wasn't sufficient, or this is actually a code issue.

Comment 10

[Michael Kurze [:michaelk]]

Stephen, did you re-navigate to the problem site or did you use the link from comment #1 -- That link is not valid anymore as clusters are re-generated every night.
When you do not use the URLs above, but navigate to the failing page as described in your report, everything seems to work out well. 

We cannot actually generate permanent links to site clusters (at least not using IDs) because they are re-generated based on a week’s comment load every night.

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Yeah, comment 0 doesn't reproduce on staging any longer, so I think this is fine.

Will either reopen or just file anew when/if I see this bug again.

Care to mark it fixed, or should I mark it WFM?  Thanks, Michael!

Comment 12

[Michael Kurze [:michaelk]]

Resolved Fixed.
Whatever this had to do with missing data is fixed. If we want more elegant URLs that never fail, we need a new bug for that.

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; In-Litmus+: https://litmus.mozilla.org/show_test.cgi?id=13807

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

As I was verifying this bug/writing the above test, I found bug 611184, which I need help better-understanding; thanks!